jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/395544 )
Change subject: Fix color of card footer icons.
......................................................................
Fix color of card footer icons.
Bug: T182099
Change-Id: I684c086ea065f98757cf509290df5aaccc65696b
---
M app/src/main/java/org/wikipedia/feed/featured/FeaturedArticleCardView.java
M app/src/main/res/layout/view_card_action_footer.xml
2 files changed, 7 insertions(+), 7 deletions(-)
Approvals:
Dbrant: Looks good to me, approved
jenkins-bot: Verified
diff --git
a/app/src/main/java/org/wikipedia/feed/featured/FeaturedArticleCardView.java
b/app/src/main/java/org/wikipedia/feed/featured/FeaturedArticleCardView.java
index a351bab..09f0d22 100644
--- a/app/src/main/java/org/wikipedia/feed/featured/FeaturedArticleCardView.java
+++ b/app/src/main/java/org/wikipedia/feed/featured/FeaturedArticleCardView.java
@@ -128,10 +128,10 @@
: new CardAddToListListener())
.onShareListener(new CardShareListener());
- if (listContainsTitle) {
-
footerView.actionIconColor(ResourceUtil.getThemedAttributeId(getContext(),
R.attr.colorAccent));
-
footerView.actionTextColor(ResourceUtil.getThemedAttributeId(getContext(),
R.attr.colorAccent));
- }
+
footerView.actionIconColor(ResourceUtil.getThemedAttributeId(getContext(),
+ listContainsTitle ? R.attr.colorAccent :
R.attr.secondary_text_color));
+
footerView.actionTextColor(ResourceUtil.getThemedAttributeId(getContext(),
+ listContainsTitle ? R.attr.colorAccent :
R.attr.secondary_text_color));
}
});
}
diff --git a/app/src/main/res/layout/view_card_action_footer.xml
b/app/src/main/res/layout/view_card_action_footer.xml
index 896d88c..0c93547 100644
--- a/app/src/main/res/layout/view_card_action_footer.xml
+++ b/app/src/main/res/layout/view_card_action_footer.xml
@@ -23,7 +23,7 @@
android:layout_height="wrap_content"
android:layout_gravity="center_vertical"
app:srcCompat="@drawable/ic_bookmark_border_black_24dp"
- android:tint="?attr/colorAccent"
+ android:tint="?attr/secondary_text_color"
android:contentDescription="@null"/>
<TextView
@@ -35,7 +35,7 @@
android:layout_marginLeft="8dp"
android:text="@string/view_featured_article_footer_save_button_label"
android:fontFamily="sans-serif-medium"
- android:textColor="?attr/colorAccent"
+ android:textColor="?attr/secondary_text_color"
android:textAllCaps="true"/>
</LinearLayout>
@@ -51,7 +51,7 @@
app:layout_constraintEnd_toEndOf="parent"
app:srcCompat="@drawable/ic_share_black_24dp"
android:scaleType="center"
- android:tint="?attr/colorAccent"
+ android:tint="?attr/secondary_text_color"
android:clickable="true"
android:background="?attr/selectableItemBackgroundBorderless"
android:contentDescription="@string/share_via"/>
--
To view, visit https://gerrit.wikimedia.org/r/395544
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I684c086ea065f98757cf509290df5aaccc65696b
Gerrit-PatchSet: 2
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Dbrant <[email protected]>
Gerrit-Reviewer: Brion VIBBER <[email protected]>
Gerrit-Reviewer: Cooltey <[email protected]>
Gerrit-Reviewer: Dbrant <[email protected]>
Gerrit-Reviewer: Sharvaniharan <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
