Sharvaniharan has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/395588 )
Change subject: Feed page cannot be updated by swiping down after changing
language at search
......................................................................
Feed page cannot be updated by swiping down after changing language at search
- Changed refresh conditions for aggregate feed to update on language change
Bug: T180529
Change-Id: Iee657a3b925a7aa2a658baf97b57d8ff67cf0296
---
M
app/src/main/java/org/wikipedia/feed/aggregated/AggregatedFeedContentClient.java
1 file changed, 3 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/apps/android/wikipedia
refs/changes/88/395588/1
diff --git
a/app/src/main/java/org/wikipedia/feed/aggregated/AggregatedFeedContentClient.java
b/app/src/main/java/org/wikipedia/feed/aggregated/AggregatedFeedContentClient.java
index a9d7f51..75bf5d9 100644
---
a/app/src/main/java/org/wikipedia/feed/aggregated/AggregatedFeedContentClient.java
+++
b/app/src/main/java/org/wikipedia/feed/aggregated/AggregatedFeedContentClient.java
@@ -158,14 +158,15 @@
public void request(@NonNull Context context, @NonNull WikiSite wiki,
int age, @NonNull Callback cb) {
this.cb = cb;
this.age = age;
- this.wiki = wiki;
- if (aggregatedClient.getCurrentAge() == age &&
aggregatedClient.getCurrentResponse() != null) {
+ boolean languageChanged = (this.wiki != null) &&
this.wiki.languageCode().equals(wiki.languageCode());
+ if (aggregatedClient.getCurrentAge() == age &&
aggregatedClient.getCurrentResponse() != null && !languageChanged) {
List<Card> cards = new ArrayList<>();
getCardFromResponse(aggregatedClient.getCurrentResponse(),
wiki, age, cards);
cb.success(cards);
} else {
aggregatedClient.requestAggregated(wiki, age, this);
}
+ this.wiki = wiki;
}
@Override
--
To view, visit https://gerrit.wikimedia.org/r/395588
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iee657a3b925a7aa2a658baf97b57d8ff67cf0296
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Sharvaniharan <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
