Ottomata has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/395593 )
Change subject: Enable async for eventbus kafka producer
......................................................................
Enable async for eventbus kafka producer
Bug: T180017
Change-Id: I4799010aad4b087600464e2a5ad9a1843fbaab4c
---
M modules/role/manifests/eventbus/eventbus.pp
1 file changed, 1 insertion(+), 11 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/operations/puppet
refs/changes/93/395593/1
diff --git a/modules/role/manifests/eventbus/eventbus.pp
b/modules/role/manifests/eventbus/eventbus.pp
index b6c50f0..f5e1aaa 100644
--- a/modules/role/manifests/eventbus/eventbus.pp
+++ b/modules/role/manifests/eventbus/eventbus.pp
@@ -63,17 +63,7 @@
# meta[topic] == mediawiki.revision_create
# in eqiad will be produced to
# eqiad.mediawiki.revsion_create
- $kafka_output_uri = $::hostname ? {
- # Temporarily test async production on kafka1001: T180017
- 'kafka1001' =>
"${kafka_base_uri}?async=True&topic=${::site}.{meta[topic]}${kafka_api_version_param}&max_request_size=${producer_request_max_size}",
- # We produce async=False so that we can be sure each request is ACKed
by Kafka
- # before we return an HTTP status, and wait up to 10 seconds for this
to happen.
- # In normal cases, this will be much much faster than 10 seconds, but
during
- # broker restarts, it can take a few seconds for meta data and
leadership
- # info to propagate to the kafka client.
- default =>
"${kafka_base_uri}?async=False&sync_timeout=10.0&topic=${::site}.{meta[topic]}${kafka_api_version_param}&max_request_size=${producer_request_max_size}",
- }
-
+ $kafka_output_uri =
"${kafka_base_uri}?async=True&topic=${::site}.{meta[topic]}${kafka_api_version_param}&max_request_size=${producer_request_max_size}"
$outputs = [$kafka_output_uri]
$access_log_level = $::realm ? {
--
To view, visit https://gerrit.wikimedia.org/r/395593
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4799010aad4b087600464e2a5ad9a1843fbaab4c
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Ottomata <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
