[MediaWiki-commits] [Gerrit] mediawiki...mobileapps[master]: Media: Add page count for paged items (PDF, TIFF)

[Mholloway (Code Review)]

Mholloway has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/395643 )

Change subject: Media: Add page count for paged items (PDF, TIFF)
......................................................................

Media: Add page count for paged items (PDF, TIFF)

Bug: T177430
Change-Id: I94b5c6222a99c7474b019191255e7bb179e23f41
---
M lib/media.js
M spec.yaml
M test/diff/results/page_media-enwiki-Hummingbird.json
M test/diff/results/page_media-enwiki-Ko%C5%A1ice.json
4 files changed, 7 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/services/mobileapps 
refs/changes/43/395643/1

diff --git a/lib/media.js b/lib/media.js
index dce92e6..aeae4e8 100644
--- a/lib/media.js
+++ b/lib/media.js
@@ -148,6 +148,7 @@
                 height: info.mediatype === 'AUDIO' ? undefined : info.height,
                 mime: info.mime,
             },
+            page_count: info.pagecount,
             file_page: `https://commons.wikimedia.org/wiki/${canonical}`,
             duration: meta && (meta.length || meta.playtime_seconds) || 
undefined,
             artist: ext && ext.Artist && ext.Artist.value,
@@ -184,6 +185,7 @@
         'url',
         'dimensions',
         'mime',
+        'size',
         'thumbmime',
         'mediatype',
         'metadata',
diff --git a/spec.yaml b/spec.yaml
index aabb1dc..714ce55 100644
--- a/spec.yaml
+++ b/spec.yaml
@@ -1285,6 +1285,9 @@
         size:
           type: integer
           description: the original file size in bytes (sizes are not provided 
for video derivatives)
+      page_count:
+        type: integer
+        description: page count, if the item is a paged item (PDF or TIFF)
       file_page:
         type: string
         description: Full URL to the file page for the item on Wikimedia 
Commons
diff --git a/test/diff/results/page_media-enwiki-Hummingbird.json 
b/test/diff/results/page_media-enwiki-Hummingbird.json
index b62bb3f..1bf7b9c 100644
--- a/test/diff/results/page_media-enwiki-Hummingbird.json
+++ b/test/diff/results/page_media-enwiki-Hummingbird.json
@@ -320,6 +320,7 @@
         "height": 2083,
         "mime": "image/tiff"
       },
+      "page_count": 1,
       "file_page": 
"https://commons.wikimedia.org/wiki/File:Velvet-purple_coronets_sequence.tif";,
       "artist": "<a 
href=\"//commons.wikimedia.org/w/index.php?title=User:Unherdable&amp;action=edit&amp;redlink=1\"
 class=\"new\" title=\"User:Unherdable (page does not exist)\">Unherdable</a>",
       "credit": "<span class=\"int-own-work\" lang=\"en\">Own work</span>",
diff --git a/test/diff/results/page_media-enwiki-Ko%C5%A1ice.json 
b/test/diff/results/page_media-enwiki-Ko%C5%A1ice.json
index 40c38e8..a2eca8a 100644
--- a/test/diff/results/page_media-enwiki-Ko%C5%A1ice.json
+++ b/test/diff/results/page_media-enwiki-Ko%C5%A1ice.json
@@ -23,6 +23,7 @@
         "height": 2202,
         "mime": "image/tiff"
       },
+      "page_count": 1,
       "file_page": 
"https://commons.wikimedia.org/wiki/File:Fő_utcza,_Kassa_-_1902_(1).tif",
       "artist": "<a 
href=\"//commons.wikimedia.org/w/index.php?title=Unknown_photographer_(scanned_by_Derzsi_Elekes_Andor)&amp;action=edit&amp;redlink=1\"
 class=\"new\" title=\"Unknown photographer (scanned by Derzsi Elekes Andor) 
(page does not exist)\">Unknown photographer (scanned by Derzsi Elekes 
Andor)</a>",
       "credit": "Courtesy of Derzsi Elekes Andor",

-- 
To view, visit https://gerrit.wikimedia.org/r/395643
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I94b5c6222a99c7474b019191255e7bb179e23f41
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/services/mobileapps
Gerrit-Branch: master
Gerrit-Owner: Mholloway <mhollo...@wikimedia.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits