jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/395045 )
Change subject: Remove wrong FIXME
......................................................................
Remove wrong FIXME
We're not going to decommission Extension:Collection anytime soon. The
FIXME meant decommissioning OCG, but there's no logic related to OCG in
that piece of code there.
Bug: T176755
Change-Id: I1922eb7c751f3947f58ce4512a5e0b4d2da6e1e6
---
M src/ElectronPdfServiceHooks.php
1 file changed, 0 insertions(+), 1 deletion(-)
Approvals:
jenkins-bot: Verified
Jdlrobson: Looks good to me, approved
diff --git a/src/ElectronPdfServiceHooks.php b/src/ElectronPdfServiceHooks.php
index e470c1d..9b3bfa1 100644
--- a/src/ElectronPdfServiceHooks.php
+++ b/src/ElectronPdfServiceHooks.php
@@ -31,7 +31,6 @@
return true;
}
- // FIXME: remove logic related to Extension:Collection once we
decommission it: T176755.
if ( $config->has( 'CollectionFormats' ) && array_key_exists(
'coll-print_export', $bar ) ) {
$index = self::getIndexOfDownloadPdfSidebarItem(
$bar['coll-print_export'],
--
To view, visit https://gerrit.wikimedia.org/r/395045
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1922eb7c751f3947f58ce4512a5e0b4d2da6e1e6
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/ElectronPdfService
Gerrit-Branch: master
Gerrit-Owner: Bmansurov <bmansu...@wikimedia.org>
Gerrit-Reviewer: Addshore <addshorew...@gmail.com>
Gerrit-Reviewer: Andrew-WMDE <andrew.kos...@wikimedia.de>
Gerrit-Reviewer: Bmansurov <bmansu...@wikimedia.org>
Gerrit-Reviewer: Jdlrobson <jrob...@wikimedia.org>
Gerrit-Reviewer: Pmiazga <pmia...@wikimedia.org>
Gerrit-Reviewer: Tobias Gritschacher <tobias.gritschac...@wikimedia.de>
Gerrit-Reviewer: WMDE-Fisch <christoph.jau...@wikimedia.de>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
