Gergő Tisza has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/395686 )
Change subject: Use lazy connection references
......................................................................
Use lazy connection references
Since we always create both read and write DB handles, but most
endpoints only use one of them, we make unnecessary connections
and cause some logspam. Using lazy references should fix that.
Change-Id: Ifd4ff81b9b04132512866300157316f8b95d2665
---
M src/Utils.php
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/ReadingLists
refs/changes/86/395686/1
diff --git a/src/Utils.php b/src/Utils.php
index 46d3fff..10136b9 100644
--- a/src/Utils.php
+++ b/src/Utils.php
@@ -26,7 +26,7 @@
$loadBalancer = $cluster
? $loadBalancerFactory->getExternalLB( $cluster )
: $loadBalancerFactory->getMainLB( $database );
- return $loadBalancer->getConnectionRef( $db, [], $database );
+ return $loadBalancer->getLazyConnectionRef( $db, [], $database
);
}
/**
--
To view, visit https://gerrit.wikimedia.org/r/395686
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifd4ff81b9b04132512866300157316f8b95d2665
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/ReadingLists
Gerrit-Branch: master
Gerrit-Owner: Gergő Tisza <gti...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
