EBernhardson has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/395856 )

Change subject: [DNM] Test xgboost4j-spark with fast hist tree maker
......................................................................

[DNM] Test xgboost4j-spark with fast hist tree maker

Change-Id: If8cda596953182a62485df9d8f370f7e6d800b51
---
M 
jvm-packages/xgboost4j-spark/src/main/scala/ml/dmlc/xgboost4j/scala/spark/XGBoost.scala
1 file changed, 4 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/search/xgboost 
refs/changes/56/395856/1

diff --git 
a/jvm-packages/xgboost4j-spark/src/main/scala/ml/dmlc/xgboost4j/scala/spark/XGBoost.scala
 
b/jvm-packages/xgboost4j-spark/src/main/scala/ml/dmlc/xgboost4j/scala/spark/XGBoost.scala
index ea18ff2..a0024a7 100644
--- 
a/jvm-packages/xgboost4j-spark/src/main/scala/ml/dmlc/xgboost4j/scala/spark/XGBoost.scala
+++ 
b/jvm-packages/xgboost4j-spark/src/main/scala/ml/dmlc/xgboost4j/scala/spark/XGBoost.scala
@@ -316,10 +316,10 @@
       eval: EvalTrait = null,
       useExternalMemory: Boolean = false,
       missing: Float = Float.NaN): XGBoostModel = {
-    if (params.contains("tree_method")) {
-      require(params("tree_method") != "hist", "xgboost4j-spark does not 
support fast histogram" +
-          " for now")
-    }
+    // if (params.contains("tree_method")) {
+    //   require(params("tree_method") != "hist", "xgboost4j-spark does not 
support fast" +
+    //       " histogram for now")
+    // }
     require(nWorkers > 0, "you must specify more than 0 workers")
     if (obj != null) {
       require(params.get("obj_type").isDefined, "parameter \"obj_type\" is not 
defined," +

-- 
To view, visit https://gerrit.wikimedia.org/r/395856
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: If8cda596953182a62485df9d8f370f7e6d800b51
Gerrit-PatchSet: 1
Gerrit-Project: search/xgboost
Gerrit-Branch: master
Gerrit-Owner: EBernhardson <ebernhard...@wikimedia.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to