jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/395861 )

Change subject: RCLFilters: Make 'target' and 'to/from' sticky
......................................................................


RCLFilters: Make 'target' and 'to/from' sticky

Make these parameters sticky to exclude them
from Saved Queries and related features
(empty, restoreDefaults).

Bug: T172161
Change-Id: Ib8b3ecd34c6af9e0983573586485a9a9f503c060
---
M resources/src/mediawiki.rcfilters/dm/mw.rcfilters.dm.FilterGroup.js
M resources/src/mediawiki.rcfilters/mw.rcfilters.Controller.js
2 files changed, 3 insertions(+), 3 deletions(-)

Approvals:
  jenkins-bot: Verified
  Mooeypoo: Looks good to me, approved



diff --git 
a/resources/src/mediawiki.rcfilters/dm/mw.rcfilters.dm.FilterGroup.js 
b/resources/src/mediawiki.rcfilters/dm/mw.rcfilters.dm.FilterGroup.js
index 1950b93..f4cdae3 100644
--- a/resources/src/mediawiki.rcfilters/dm/mw.rcfilters.dm.FilterGroup.js
+++ b/resources/src/mediawiki.rcfilters/dm/mw.rcfilters.dm.FilterGroup.js
@@ -786,7 +786,7 @@
                var state = {};
 
                this.getItems().forEach( function ( filterItem ) {
-                       state[ filterItem.getName() ] = filterItem.isSelected();
+                       state[ filterItem.getName() ] = filterItem.getValue();
                } );
 
                return state;
diff --git a/resources/src/mediawiki.rcfilters/mw.rcfilters.Controller.js 
b/resources/src/mediawiki.rcfilters/mw.rcfilters.Controller.js
index 8d5b815..eec4f4b 100644
--- a/resources/src/mediawiki.rcfilters/mw.rcfilters.Controller.js
+++ b/resources/src/mediawiki.rcfilters/mw.rcfilters.Controller.js
@@ -195,7 +195,7 @@
                                        type: 'any_value',
                                        title: '',
                                        hidden: true,
-                                       isSticky: false,
+                                       sticky: true,
                                        filters: [
                                                {
                                                        name: 'target',
@@ -208,7 +208,7 @@
                                        type: 'boolean',
                                        title: '',
                                        hidden: true,
-                                       isSticky: false,
+                                       sticky: true,
                                        filters: [
                                                {
                                                        name: 'showlinkedto',

-- 
To view, visit https://gerrit.wikimedia.org/r/395861
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ib8b3ecd34c6af9e0983573586485a9a9f503c060
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Sbisson <sbis...@wikimedia.org>
Gerrit-Reviewer: Mooeypoo <mor...@gmail.com>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to