Dzahn has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/395890 )
Change subject: ganglia: delete views for kafkatee, hadoop, varnishkafka ...................................................................... ganglia: delete views for kafkatee, hadoop, varnishkafka Can these Ganglia views be removed? The one for kafkatee is still working, the other 2 are already turned off as part of decom'ing Ganglia across the fleet. Without deleting the kafkatee view i get puppet errors on oxygen when trying to remove Ganglia. Just wanted to confirm these can go and you are using Grafana or something else. Thanks. kafkatee view: https://ganglia.wikimedia.org/latest/?r=hour&cs=&ce=&m=cpu_report&s=by+name&c=&tab=v&vn=&hide-hf=false hadoop view: https://ganglia.wikimedia.org/latest/?r=hour&cs=&ce=&m=cpu_report&s=by+name&c=&tab=v&vn=&hide-hf=false kafka view: https://ganglia.wikimedia.org/latest/?r=hour&cs=&ce=&m=cpu_report&s=by+name&c=&tab=v&vn=&hide-hf=false Bug: T177225 Change-Id: I57ed4b0a2bf772d7ad05083c543745df505aadfe --- D modules/ganglia/manifests/views/hadoop.pp D modules/ganglia/manifests/views/kafkatee.pp D modules/ganglia/manifests/views/varnishkafka.pp 3 files changed, 0 insertions(+), 214 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/operations/puppet refs/changes/90/395890/1 diff --git a/modules/ganglia/manifests/views/hadoop.pp b/modules/ganglia/manifests/views/hadoop.pp deleted file mode 100644 index b49d1cf..0000000 --- a/modules/ganglia/manifests/views/hadoop.pp +++ /dev/null @@ -1,93 +0,0 @@ -class ganglia::views::hadoop( - $master, - $worker_regex, - $ensure = 'present') { - - ganglia::web::view { 'hadoop': - ensure => $ensure, - graphs => [ - # ResourceManager active applications - { - 'host_regex' => $master, - 'metric_regex' => 'Hadoop.ResourceManager.QueueMetrics.*ActiveApplications', - 'type' => 'stack', - }, - # ResourceManager failed applications - { - 'host_regex' => $master, - 'metric_regex' => 'Hadoop.ResourceManager.QueueMetrics.*AppsFailed', - 'type' => 'stack', - }, - # NodeManager containers running - { - 'host_regex' => $worker_regex, - 'metric_regex' => 'Hadoop.NodeManager.NodeManagerMetrics.ContainersRunning', - 'type' => 'stack', - }, - # NodeManager Allocated Memeory GB - { - 'host_regex' => $worker_regex, - 'metric_regex' => 'Hadoop.NodeManager.NodeManagerMetrics.AllocatedGB', - 'type' => 'stack', - }, - # Worker Node bytes_in - { - 'host_regex' => $worker_regex, - 'metric_regex' => 'bytes_in', - 'type' => 'stack', - }, - # Worker Node bytes_out - { - 'host_regex' => $worker_regex, - 'metric_regex' => 'bytes_out', - 'type' => 'stack', - }, - # Primary NameNode File activity - { - 'host_regex' => $master, - 'metric_regex' => 'Hadoop.NameNode.NameNodeActivity.Files(Created|Deleted|Renamed|Appended)', - 'type' => 'line', - }, - # Worker Node /proc/diskstat bytes written per second - { - # FIXME - top-scope var without namespace ($worker_regex), will break in puppet 2.8 - # lint:ignore:variable_scope - 'host_regex' => $worker_regex, - 'metric_regex' => "diskstat_(${kafka_log_disks_regex})_write_bytes_per_sec", - 'type' => 'stack', - }, - # /proc/diskstat bytes read per second - { - 'host_regex' => $worker_regex, - 'metric_regex' => "diskstat_(${kafka_log_disks_regex})_read_bytes_per_sec", - 'type' => 'stack', - }, - # Worker Node /proc/diskstat disk utilization % - { - 'host_regex' => $worker_regex, - 'metric_regex' => "diskstat_(${kafka_log_disks_regex})_percent_io_time", - 'type' => 'line', - }, - # Worker Node /proc/diskstat IO time - { - 'host_regex' => $worker_regex, - 'metric_regex' => "diskstat_(${kafka_log_disks_regex})_io_time", - 'type' => 'line', - }, - # lint:endignore - # Worker Node 15 minute load average - { - 'host_regex' => $worker_regex, - 'metric_regex' => 'load_fifteen', - 'type' => 'line', - }, - # Worker Node IO wait - { - 'host_regex' => $worker_regex, - 'metric_regex' => 'cpu_wio', - 'type' => 'line', - }, - ], - } -} - diff --git a/modules/ganglia/manifests/views/kafkatee.pp b/modules/ganglia/manifests/views/kafkatee.pp deleted file mode 100644 index ce3d196..0000000 --- a/modules/ganglia/manifests/views/kafkatee.pp +++ /dev/null @@ -1,37 +0,0 @@ -class ganglia::views::kafkatee( - $kafkatee_host_regex, - $topic_regex = '.+', - $ensure = 'present') { - - ganglia::web::view { 'kafkatee': - ensure => $ensure, - graphs => [ - # receive transctions per second rate - { - 'host_regex' => $kafkatee_host_regex, - 'metric_regex' => 'kafka.rdkafka.brokers..+\.rx\.per_second', - 'type' => 'stack', - }, - # receive bytes per second rate - { - 'host_regex' => $kafkatee_host_regex, - 'metric_regex' => 'kafka.rdkafka.brokers..+\.rxbytes\.per_second', - 'type' => 'stack', - }, - # round trip time average - { - 'host_regex' => $kafkatee_host_regex, - 'metric_regex' => 'kafka.rdkafka.brokers..+\.rtt\.avg', - 'type' => 'line', - }, - # next_offset.per_second - rate at which offset is updated, - # meaning how many offsets per second are read - { - 'host_regex' => $kafkatee_host_regex, - 'metric_regex' => "kafka.rdkafka.topics.${topic_regex}\\.next_offset.per_second", - 'type' => 'stack', - }, - ], - } -} - diff --git a/modules/ganglia/manifests/views/varnishkafka.pp b/modules/ganglia/manifests/views/varnishkafka.pp deleted file mode 100644 index a43038f..0000000 --- a/modules/ganglia/manifests/views/varnishkafka.pp +++ /dev/null @@ -1,84 +0,0 @@ -define ganglia::views::varnishkafka( - $varnishkafka_host_regex = 'cp.+', - $topic_regex = '.+', - $ensure = 'present') { - - ganglia::web::view { "varnishkafka-${title}": - ensure => $ensure, - graphs => [ - # delivery report error rate - { - 'host_regex' => $varnishkafka_host_regex, - 'metric_regex' => 'kafka.varnishkafka\.kafka_drerr.per_second', - 'type' => 'line', - }, - # delivery report errors. - # drerr is important, but seems to happen in bursts. - # let's show the total drerr in the view as well. - { - 'host_regex' => $varnishkafka_host_regex, - 'metric_regex' => 'kafka.varnishkafka\.kafka_drerr$', - 'type' => 'line', - }, - # transaction error rate - { - 'host_regex' => $varnishkafka_host_regex, - 'metric_regex' => 'kafka.varnishkafka\.txerr.per_second', - 'type' => 'line', - }, - - # round trip time average - { - 'host_regex' => $varnishkafka_host_regex, - 'metric_regex' => 'kafka.rdkafka.brokers..+\.rtt\.avg', - 'type' => 'line', - }, - - - ## These graphs are large, and I don't use them much. Disabling them in this view for now. - ## https://phabricator.wikimedia.org/T97637 - # Queues: - # msgq -> xmit_msgq -> outbuf -> waitresp - - # # message queue count - # { - # 'host_regex' => $varnishkafka_host_regex, - # 'metric_regex' => "kafka.rdkafka.topics.${topic_regex}\\.msgq_cnt", - # 'type' => 'line', - # }, - # # transmit message queue count - # { - # 'host_regex' => $varnishkafka_host_regex, - # 'metric_regex' => "kafka.rdkafka.topics.${topic_regex}\\.xmit_msgq_cnt", - # 'type' => 'line', - # }, - # # output buffer queue count - # { - # 'host_regex' => $varnishkafka_host_regex, - # 'metric_regex' => 'kafka.rdkafka.brokers..+\.outbuf_cnt', - # 'type' => 'line', - # }, - # # waiting for response buffer count - # { - # 'host_regex' => $varnishkafka_host_regex, - # 'metric_regex' => 'kafka.rdkafka.brokers..+\.waitresp_cnt', - # 'type' => 'line', - # }, - # - # # transaction bytes rate - # { - # 'host_regex' => $varnishkafka_host_regex, - # 'metric_regex' => "kafka.rdkafka.topics.${topic_regex}\\.txbytes.per_second", - # 'type' => 'stack', - # }, - - # transaction messages rate - { - 'host_regex' => $varnishkafka_host_regex, - 'metric_regex' => "kafka.rdkafka.topics.${topic_regex}\\.txmsgs.per_second", - 'type' => 'stack', - }, - ], - } -} - -- To view, visit https://gerrit.wikimedia.org/r/395890 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I57ed4b0a2bf772d7ad05083c543745df505aadfe Gerrit-PatchSet: 1 Gerrit-Project: operations/puppet Gerrit-Branch: production Gerrit-Owner: Dzahn <dz...@wikimedia.org> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
