jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/394662 )
Change subject: Remove unused globals
......................................................................
Remove unused globals
Change-Id: I29163c101a65bae74893c715db9d75a4e73b8f76
---
M includes/forminputs/PF_DatePickerInput.php
M includes/forminputs/PF_RatingInput.php
M includes/forminputs/PF_TimePickerInput.php
3 files changed, 1 insertion(+), 10 deletions(-)
Approvals:
jenkins-bot: Verified
Thiemo Mättig (WMDE): Looks good to me, approved
diff --git a/includes/forminputs/PF_DatePickerInput.php
b/includes/forminputs/PF_DatePickerInput.php
index 67ce5b0..447d079 100644
--- a/includes/forminputs/PF_DatePickerInput.php
+++ b/includes/forminputs/PF_DatePickerInput.php
@@ -585,8 +585,6 @@
* TODO: Add missing parameters
*/
public static function getParameters() {
- global $wgPageFormsDatePickerSettings;
-
$params = parent::getParameters();
$params['date format'] = array(
'name' => 'date format',
diff --git a/includes/forminputs/PF_RatingInput.php
b/includes/forminputs/PF_RatingInput.php
index 042cae8..35529b1 100644
--- a/includes/forminputs/PF_RatingInput.php
+++ b/includes/forminputs/PF_RatingInput.php
@@ -52,7 +52,7 @@
* Returns the HTML code to be included in the output page for this
input.
*/
public function getHtmlText() {
- global $wgPageFormsFieldNum, $wgPageFormsShowOnSelect;
+ global $wgPageFormsFieldNum;
$className = 'pfRating';
if ( $this->mIsMandatory ) {
diff --git a/includes/forminputs/PF_TimePickerInput.php
b/includes/forminputs/PF_TimePickerInput.php
index 65de81c..815cf37 100644
--- a/includes/forminputs/PF_TimePickerInput.php
+++ b/includes/forminputs/PF_TimePickerInput.php
@@ -65,8 +65,6 @@
if ( array_key_exists( 'mintime', $this->mOtherArgs )
&& ( preg_match( '/^\d+:\d\d$/', trim(
$this->mOtherArgs['mintime'] ) ) == 1 ) ) {
$minTime = trim( $this->mOtherArgs['mintime'] );
-// } elseif ( $sfigSettings->timePickerMinTime != null ) {
-// $minTime = $sfigSettings->timePickerMinTime;
} else {
$minTime = '00:00';
}
@@ -75,8 +73,6 @@
if ( array_key_exists( 'maxtime', $this->mOtherArgs )
&& ( preg_match( '/^\d+:\d\d$/', trim(
$this->mOtherArgs['maxtime'] ) ) == 1 ) ) {
$maxTime = trim( $this->mOtherArgs['maxtime'] );
-// } elseif ( $sfigSettings->timePickerMaxTime != null ) {
-// $maxTime = $sfigSettings->timePickerMaxTime;
} else {
$maxTime = '23:59';
}
@@ -149,9 +145,6 @@
* TODO: Specify parameters specific for menuselect.
*/
public static function getParameters() {
-
- global $sfigSettings;
-
$params = parent::getParameters();
$params['mintime'] = array(
'name' => 'mintime',
--
To view, visit https://gerrit.wikimedia.org/r/394662
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I29163c101a65bae74893c715db9d75a4e73b8f76
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/PageForms
Gerrit-Branch: master
Gerrit-Owner: Umherirrender <[email protected]>
Gerrit-Reviewer: Thiemo Mättig (WMDE) <[email protected]>
Gerrit-Reviewer: Yaron Koren <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
