jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/395513 )
Change subject: Update RuboCop Ruby gem ...................................................................... Update RuboCop Ruby gem Bug: T180878 Change-Id: I470fdf4b24d42bac3852f3d8d03ea06d0e01462d --- M .rubocop.yml A .rubocop_todo.yml M mediawiki_selenium.gemspec 3 files changed, 73 insertions(+), 1 deletion(-) Approvals: Zfilipin: Looks good to me, approved jenkins-bot: Verified diff --git a/.rubocop.yml b/.rubocop.yml index 60ae00f..7d388db 100644 --- a/.rubocop.yml +++ b/.rubocop.yml @@ -1,3 +1,5 @@ +inherit_from: .rubocop_todo.yml + AllCops: DisplayCopNames: true StyleGuideCopsOnly: true diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml new file mode 100644 index 0000000..d8f4947 --- /dev/null +++ b/.rubocop_todo.yml @@ -0,0 +1,67 @@ +# This configuration was generated by +# `rubocop --auto-gen-config` +# on 2017-12-05 13:20:08 +0100 using RuboCop version 0.51.0. +# The point is for the user to remove these configuration records +# one by one as the offenses are removed from the code base. +# Note that changes in the inspected code, or installation of new +# versions of RuboCop, may require this file to be generated again. + +# Offense count: 1 +# Cop supports --auto-correct. +Layout/EmptyLineAfterMagicComment: + Exclude: + - 'mediawiki_selenium.gemspec' + +# Offense count: 1 +# Cop supports --auto-correct. +Layout/EmptyLines: + Exclude: + - 'lib/mediawiki_selenium/step_definitions/upload_file_steps.rb' + +# Offense count: 2 +# Cop supports --auto-correct. +# Configuration parameters: EnforcedStyle, SupportedStyles. +# SupportedStyles: empty_lines, no_empty_lines +Layout/EmptyLinesAroundBlockBody: + Exclude: + - 'spec/environment_spec.rb' + +# Offense count: 1 +# Cop supports --auto-correct. +# Configuration parameters: EnforcedStyle, SupportedStyles. +# SupportedStyles: auto_detection, squiggly, active_support, powerpack, unindent +Layout/IndentHeredoc: + Exclude: + - 'lib/mediawiki_selenium/step_definitions/resource_loader_steps.rb' + +# Offense count: 2 +# Configuration parameters: EnforcedStyle, SupportedStyles. +# SupportedStyles: lowercase, uppercase +Naming/HeredocDelimiterCase: + Exclude: + - 'lib/mediawiki_selenium/step_definitions/resource_loader_steps.rb' + - 'mediawiki_selenium.gemspec' + +# Offense count: 5 +# Configuration parameters: EnforcedStyle, SupportedStyles. +# SupportedStyles: nested, compact +Style/ClassAndModuleChildren: + Exclude: + - 'lib/mediawiki_selenium/cucumber/sauce.rb' + - 'spec/browser_factory/base_spec.rb' + - 'spec/browser_factory/chrome_spec.rb' + - 'spec/browser_factory/firefox_spec.rb' + - 'spec/browser_factory/phantomjs_spec.rb' + +# Offense count: 1 +# Cop supports --auto-correct. +Style/Encoding: + Exclude: + - 'mediawiki_selenium.gemspec' + +# Offense count: 7 +# Cop supports --auto-correct. +# Configuration parameters: MinSize, SupportedStyles. +# SupportedStyles: percent, brackets +Style/SymbolArray: + EnforcedStyle: brackets diff --git a/mediawiki_selenium.gemspec b/mediawiki_selenium.gemspec index bc46831..0593c71 100644 --- a/mediawiki_selenium.gemspec +++ b/mediawiki_selenium.gemspec @@ -30,6 +30,9 @@ spec.required_ruby_version = '~> 2.0' spec.add_runtime_dependency 'cucumber', '~> 1.3', '>= 1.3.20' + # Locking data_magic to version 1.1 because 1.2 requires Ruby version >= 2.2 and + # Jenkins is on 2.1.0 + spec.add_runtime_dependency 'data_magic', '~> 1.1.0' spec.add_runtime_dependency 'headless', '~> 2.0', '>= 2.1.0' spec.add_runtime_dependency 'json', '~> 2.0', '>= 2.0.2' spec.add_runtime_dependency 'mediawiki_api', '~> 0.7', '>= 0.7.0' @@ -45,6 +48,6 @@ spec.add_development_dependency 'bundler', '~> 1.6', '>= 1.6.3' spec.add_development_dependency 'yard', '~> 0.8', '>= 0.8.7.4' spec.add_development_dependency 'redcarpet', '~> 3.2', '>= 3.2.0' - spec.add_development_dependency 'rubocop', '~> 0.46.0' + spec.add_development_dependency 'rubocop', '~> 0.51.0' spec.add_development_dependency 'rspec-mocks', '~> 2.14', '>= 2.14.4' end -- To view, visit https://gerrit.wikimedia.org/r/395513 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I470fdf4b24d42bac3852f3d8d03ea06d0e01462d Gerrit-PatchSet: 2 Gerrit-Project: mediawiki/selenium Gerrit-Branch: master Gerrit-Owner: Zfilipin <[email protected]> Gerrit-Reviewer: Dduvall <[email protected]> Gerrit-Reviewer: Hashar <[email protected]> Gerrit-Reviewer: Zfilipin <[email protected]> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
