jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/395954 )
Change subject: Unbreak query APIs
......................................................................
Unbreak query APIs
Apparently a null value for MAX2 works with the API help
but errors out when actually using the API. Setting it to the same
as MAX doesn't work well in help (will say something like
"limit is 10 (10 for bots)" which looks silly) but actually works.
That should probably be fixed upstream but for now let's go with
the latter.
Change-Id: Iee3f28cc9ca014c04461294ec5e9619365dac8c5
---
M src/Api/ApiQueryTrait.php
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
jenkins-bot: Verified
Mholloway: Looks good to me, approved
diff --git a/src/Api/ApiQueryTrait.php b/src/Api/ApiQueryTrait.php
index b95ea54..89b2a45 100644
--- a/src/Api/ApiQueryTrait.php
+++ b/src/Api/ApiQueryTrait.php
@@ -123,7 +123,7 @@
self::PARAM_MIN => 1,
// Temporarily limit paging sizes per
T164990#3264314 / T168984#3659998
self::PARAM_MAX => self::$prefix === 'rl' ? 10
: 100,
- self::PARAM_MAX2 => null,
+ self::PARAM_MAX2 => self::$prefix === 'rl' ? 10
: 100,
],
'continue' => [
self::PARAM_TYPE => 'string',
--
To view, visit https://gerrit.wikimedia.org/r/395954
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iee3f28cc9ca014c04461294ec5e9619365dac8c5
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/ReadingLists
Gerrit-Branch: master
Gerrit-Owner: Gergő Tisza <[email protected]>
Gerrit-Reviewer: Mholloway <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
