jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/396004 )
Change subject: rake job: gemspec is a file suffix
......................................................................
rake job: gemspec is a file suffix
Zuul files: filtering uses re.match() which checks at the beginning of
the string as indicated by the comment.
We were not running the job for a patch changing solely a gemspec for
example:
M mediawiki_api.gemspec
Change-Id: Ie060b9c6646c6812920c68096f71e75c0f3c548e
---
M tests/test_zuul_scheduler.py
M zuul/layout.yaml
2 files changed, 2 insertions(+), 1 deletion(-)
Approvals:
Zfilipin: Looks good to me, approved
jenkins-bot: Verified
diff --git a/tests/test_zuul_scheduler.py b/tests/test_zuul_scheduler.py
index 0b445fd..dea584b 100644
--- a/tests/test_zuul_scheduler.py
+++ b/tests/test_zuul_scheduler.py
@@ -675,6 +675,7 @@
(True, ['foo/task.rb']),
(True, ['module/spec/foo']),
(True, ['Gemfile.lock']),
+ (True, ['mediawiki_api.gemspec']),
(False, ['foo.php']),
]
diff --git a/zuul/layout.yaml b/zuul/layout.yaml
index ed8ee33..236516f 100644
--- a/zuul/layout.yaml
+++ b/zuul/layout.yaml
@@ -754,7 +754,7 @@
# Uses python re.match() which checks at BEGINNING of the string
- '.*\.pp$'
- '.*\.rb'
- - '(\.rubocop|\.gemspec|Gemfile)'
+ - '(\.rubocop|.*\.gemspec$|Gemfile)'
- '.*([Rr]akefile|/spec/)'
# Same for mediawiki/vagrant
--
To view, visit https://gerrit.wikimedia.org/r/396004
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie060b9c6646c6812920c68096f71e75c0f3c548e
Gerrit-PatchSet: 2
Gerrit-Project: integration/config
Gerrit-Branch: master
Gerrit-Owner: Hashar <[email protected]>
Gerrit-Reviewer: Paladox <[email protected]>
Gerrit-Reviewer: Zfilipin <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
