awjrichards has submitted this change and it was merged.
Change subject: Use embed the correct way, fix Nokia N95s
......................................................................
Use embed the correct way, fix Nokia N95s
This is producing invalid css which is breaking the mobile
experience for a variety of older phones who cannot handle css parse
errors.
Change-Id: Ie0dadd0773ea1c585083de6eeff04d009442a176
---
M less/common/mainmenu.less
M less/common/mf-navigation.less
M stylesheets/common/mf-navigation.css
M stylesheets/common/ui.css
4 files changed, 25 insertions(+), 16 deletions(-)
Approvals:
Brion VIBBER: Checked; Looks good to me, but someone else must approve
awjrichards: Verified; Looks good to me, approved
diff --git a/less/common/mainmenu.less b/less/common/mainmenu.less
index 3b7a918..9442810 100644
--- a/less/common/mainmenu.less
+++ b/less/common/mainmenu.less
@@ -51,31 +51,31 @@
}
&.icon-home a {
- background-image: /* @embed */url(images/menu/home.png);
+ /* @embed */background-image: url(images/menu/home.png);
}
&.icon-random a {
- background-image: /* @embed
*/url(images/menu/random.png);
+ /* @embed */background-image:
url(images/menu/random.png);
}
&.icon-watchlist a {
- background-image: /* @embed
*/url(images/menu/watchlist.png);
+ /* @embed */background-image:
url(images/menu/watchlist.png);
}
&.icon-uploads a {
- background-image: /* @embed
*/url(images/menu/uploads.png);
+ /* @embed */background-image:
url(images/menu/uploads.png);
}
&.icon-nearby a {
- background-image: /* @embed
*/url(images/menu/nearby.png);
+ /* @embed */background-image:
url(images/menu/nearby.png);
}
&.icon-settings a {
- background-image: /* @embed
*/url(images/menu/settings.png);
+ /* @embed */background-image:
url(images/menu/settings.png);
}
&.icon-loginout a {
- background-image: /* @embed
*/url(images/menu/loginout.png);
+ /* @embed */background-image:
url(images/menu/loginout.png);
}
}
}
diff --git a/less/common/mf-navigation.less b/less/common/mf-navigation.less
index e234766..f326ab5 100644
--- a/less/common/mf-navigation.less
+++ b/less/common/mf-navigation.less
@@ -16,7 +16,8 @@
.client-js {
#mw-mf-main-menu-button {
- background-image: /* @embed */ url(images/menu/main.png);
+ /* @embed */background-image: url(images/menu/main.png);
+
}
}
diff --git a/stylesheets/common/mf-navigation.css
b/stylesheets/common/mf-navigation.css
index d2f52b0..3fbbb26 100644
--- a/stylesheets/common/mf-navigation.css
+++ b/stylesheets/common/mf-navigation.css
@@ -2,7 +2,8 @@
right: 0;
}
.client-js #mw-mf-main-menu-button {
- background-image: /* @embed */ url(images/menu/main.png);
+ /* @embed */
+ background-image: url(images/menu/main.png);
}
#mw-mf-viewport {
width: 100%;
diff --git a/stylesheets/common/ui.css b/stylesheets/common/ui.css
index af23f98..cc2c5fc 100644
--- a/stylesheets/common/ui.css
+++ b/stylesheets/common/ui.css
@@ -174,25 +174,32 @@
text-decoration: none;
}
#mw-mf-menu-main li.icon-home a {
- background-image: /* @embed */ url(images/menu/home.png);
+ /* @embed */
+ background-image: url(images/menu/home.png);
}
#mw-mf-menu-main li.icon-random a {
- background-image: /* @embed */ url(images/menu/random.png);
+ /* @embed */
+ background-image: url(images/menu/random.png);
}
#mw-mf-menu-main li.icon-watchlist a {
- background-image: /* @embed */ url(images/menu/watchlist.png);
+ /* @embed */
+ background-image: url(images/menu/watchlist.png);
}
#mw-mf-menu-main li.icon-uploads a {
- background-image: /* @embed */ url(images/menu/uploads.png);
+ /* @embed */
+ background-image: url(images/menu/uploads.png);
}
#mw-mf-menu-main li.icon-nearby a {
- background-image: /* @embed */ url(images/menu/nearby.png);
+ /* @embed */
+ background-image: url(images/menu/nearby.png);
}
#mw-mf-menu-main li.icon-settings a {
- background-image: /* @embed */ url(images/menu/settings.png);
+ /* @embed */
+ background-image: url(images/menu/settings.png);
}
#mw-mf-menu-main li.icon-loginout a {
- background-image: /* @embed */ url(images/menu/loginout.png);
+ /* @embed */
+ background-image: url(images/menu/loginout.png);
}
@media all and (min-width: 700px) {
.navigationEnabled .alpha #mw-mf-page-left,
--
To view, visit https://gerrit.wikimedia.org/r/56956
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie0dadd0773ea1c585083de6eeff04d009442a176
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson <jrob...@wikimedia.org>
Gerrit-Reviewer: Brion VIBBER <br...@wikimedia.org>
Gerrit-Reviewer: Dr0ptp4kt <ab...@wikimedia.org>
Gerrit-Reviewer: JGonera <jgon...@wikimedia.org>
Gerrit-Reviewer: Yurik <yu...@wikimedia.org>
Gerrit-Reviewer: awjrichards <aricha...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
