Addshore has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/396402 )

Change subject: NewRevisionFromEditComplete WikiPage typehint
......................................................................

NewRevisionFromEditComplete WikiPage typehint

Change-Id: I83b28eb517c6420d13103da53d802a8c122e22ff
---
M PageTriage.hooks.php
1 file changed, 10 insertions(+), 7 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/PageTriage 
refs/changes/02/396402/1

diff --git a/PageTriage.hooks.php b/PageTriage.hooks.php
index debd516..1ddef2b 100644
--- a/PageTriage.hooks.php
+++ b/PageTriage.hooks.php
@@ -59,26 +59,29 @@
         * Note: Page will be automatically marked as triaged for users with 
autopatrol right
         *
         * @see 
http://www.mediawiki.org/wiki/Manual:Hooks/NewRevisionFromEditComplete
-        * @param WikiPage $page the WikiPage edited
+        *
+        * @param WikiPage $wikiPage the WikiPage edited
         * @param Revision|null $rev the new revision
         * @param int $baseID the revision ID this was based on, if any
         * @param User $user the editing user
+        *
         * @return bool
         */
-       public static function onNewRevisionFromEditComplete( $page, $rev, 
$baseID, $user ) {
+       public static function onNewRevisionFromEditComplete( WikiPage 
$wikiPage, $rev, $baseID, $user ) {
                global $wgPageTriageNamespaces;
 
-               if ( !in_array( $page->getTitle()->getNamespace(), 
$wgPageTriageNamespaces ) ) {
+               if ( !in_array( $wikiPage->getTitle()->getNamespace(), 
$wgPageTriageNamespaces ) ) {
                        return true;
                }
 
                if ( $rev && $rev->getParentId() ) {
                        // Make sure $prev->getContent() is done post-send if 
possible
-                       DeferredUpdates::addCallableUpdate( function () use ( 
$rev, $page, $user ) {
+                       DeferredUpdates::addCallableUpdate( function () use ( 
$rev, $wikiPage, $user ) {
                                $prev = $rev->getPrevious();
-                               if ( $prev && !$page->isRedirect() && 
$prev->getContent()->isRedirect() ) {
+                               if ( $prev && !$wikiPage->isRedirect() && 
$prev->getContent()->isRedirect() ) {
                                        PageTriageHooks::addToPageTriageQueue(
-                                               $page->getId(), 
$page->getTitle(), $user );
+                                               $wikiPage->getId(),
+                                               $wikiPage->getTitle(), $user );
                                }
                        } );
                }
@@ -135,7 +138,7 @@
                $article, $user, $content, $summary, $minoredit, $watchthis, 
$sectionanchor, $flags, $revision,
                $status, $baseRevId
        ) {
-               self::flushUserStatusCache( $article->getTitle() );
+               self::flushUserStatusCgache( $article->getTitle() );
                return true;
        }
 

-- 
To view, visit https://gerrit.wikimedia.org/r/396402
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I83b28eb517c6420d13103da53d802a8c122e22ff
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/PageTriage
Gerrit-Branch: master
Gerrit-Owner: Addshore <addshorew...@gmail.com>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to