jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/396424 )
Change subject: Fix occasional bug in Randomizer.
......................................................................
Fix occasional bug in Randomizer.
One out of ten times, when first loading the Randomizer activity, the
first item appears with a blank summary. This patch fixes this condition.
Change-Id: Ie771374b4264bed165a0234d3a6dab90dc2c9f15
---
M app/src/main/java/org/wikipedia/random/RandomItemFragment.java
1 file changed, 3 insertions(+), 1 deletion(-)
Approvals:
Sharvaniharan: Looks good to me, approved
jenkins-bot: Verified
diff --git a/app/src/main/java/org/wikipedia/random/RandomItemFragment.java
b/app/src/main/java/org/wikipedia/random/RandomItemFragment.java
index adbc7fb..71c766f 100644
--- a/app/src/main/java/org/wikipedia/random/RandomItemFragment.java
+++ b/app/src/main/java/org/wikipedia/random/RandomItemFragment.java
@@ -109,7 +109,9 @@
if (!isAdded() || extractView == null) {
return;
}
- extractView.setMaxLines(extractView.getHeight() /
extractView.getLineHeight());
+ int maxLines = extractView.getHeight() /
extractView.getLineHeight() - 1;
+ final int minLines = 3;
+ extractView.setMaxLines(Math.max(maxLines, minLines));
extractView.getViewTreeObserver().removeOnGlobalLayoutListener(this);
}
});
--
To view, visit https://gerrit.wikimedia.org/r/396424
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie771374b4264bed165a0234d3a6dab90dc2c9f15
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Dbrant <[email protected]>
Gerrit-Reviewer: Brion VIBBER <[email protected]>
Gerrit-Reviewer: Cooltey <[email protected]>
Gerrit-Reviewer: Sharvaniharan <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
