Ori.livneh has uploaded a new change for review.
https://gerrit.wikimedia.org/r/57203
Change subject: Fixes to docblocks; drop nonstandard cursor: hand; CSS attr.
......................................................................
Fixes to docblocks; drop nonstandard cursor: hand; CSS attr.
Change-Id: I0ca98f706e8d3dd7b36dc5887fb613eed3f4c68c
---
M EventLogging.php
M includes/JsonSchemaContent.php
M modules/ext.eventLogging.core.js
M modules/ext.eventLogging.jsonSchema.css
4 files changed, 5 insertions(+), 3 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/EventLogging
refs/changes/03/57203/1
diff --git a/EventLogging.php b/EventLogging.php
index cdc5312..6c3c069 100644
--- a/EventLogging.php
+++ b/EventLogging.php
@@ -91,7 +91,7 @@
*
* @see wfErrorLog
*
- * @param string $schema: Schema name.
+ * @param string $schemaName: Schema name.
* @param integer $revId: revision ID of schema
* @param array $event: Map of event keys/vals.
* @return bool: Whether the event was logged.
diff --git a/includes/JsonSchemaContent.php b/includes/JsonSchemaContent.php
index 840ee10..9ab83ee 100644
--- a/includes/JsonSchemaContent.php
+++ b/includes/JsonSchemaContent.php
@@ -55,6 +55,7 @@
/**
* Constructs an HTML representation of a JSON object.
+ * @param Array $mapping
* @return string: HTML.
*/
static function objectTable( $mapping ) {
@@ -70,6 +71,8 @@
/**
* Constructs HTML representation of a single key-value pair.
+ * @param string $key
+ * @param mixed $val
* @return string: HTML.
*/
static function objectRow( $key, $val ) {
diff --git a/modules/ext.eventLogging.core.js b/modules/ext.eventLogging.core.js
index c2be7df..239cb32 100644
--- a/modules/ext.eventLogging.core.js
+++ b/modules/ext.eventLogging.core.js
@@ -86,7 +86,7 @@
* number types. Arrays are not currently supported.
*
* @method isInstanceOf
- * @param {Object} instance Object to test.
+ * @param {Object} value Object to test.
* @param {String} type JSON Schema type.
* @return {Boolean} Whether value is instance of type.
*/
diff --git a/modules/ext.eventLogging.jsonSchema.css
b/modules/ext.eventLogging.jsonSchema.css
index 5aff1de..092301b 100644
--- a/modules/ext.eventLogging.jsonSchema.css
+++ b/modules/ext.eventLogging.jsonSchema.css
@@ -79,7 +79,6 @@
right: 0;
top: -.9em;
padding: 0.1em;
- cursor: hand;
cursor: pointer;
transition: background-color .5s;
}
--
To view, visit https://gerrit.wikimedia.org/r/57203
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0ca98f706e8d3dd7b36dc5887fb613eed3f4c68c
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/EventLogging
Gerrit-Branch: master
Gerrit-Owner: Ori.livneh <o...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
