Daniel Werner has submitted this change and it was merged.
Change subject: (bug 44228) Explicit "undefined" check in EditableValue
......................................................................
(bug 44228) Explicit "undefined" check in EditableValue
Using jQuery's $.inArray to check for "undefined" does not work in IE8.
Change-Id: I3ecab59732391e5b2b88964937085a7bee082f4f
---
M lib/resources/wikibase.ui.PropertyEditTool.EditableValue.js
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Daniel Werner: Verified; Looks good to me, approved
jenkins-bot: Checked
diff --git a/lib/resources/wikibase.ui.PropertyEditTool.EditableValue.js
b/lib/resources/wikibase.ui.PropertyEditTool.EditableValue.js
index 13b5483..67c21e1 100644
--- a/lib/resources/wikibase.ui.PropertyEditTool.EditableValue.js
+++ b/lib/resources/wikibase.ui.PropertyEditTool.EditableValue.js
@@ -67,7 +67,7 @@
// Overwritten constructor:
function( subject, options, interfaces, toolbar ) {
// allow toolbar not to be set, even though it is still
required inside in many places
- if( $.inArray( undefined, [ subject, interfaces ] ) === -1 ) {
+ if( subject !== undefined && interfaces !== undefined ) {
this.init( subject, options, interfaces, toolbar );
}
}, {
--
To view, visit https://gerrit.wikimedia.org/r/57072
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3ecab59732391e5b2b88964937085a7bee082f4f
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Henning Snater <[email protected]>
Gerrit-Reviewer: Daniel Werner <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
