Catrope has uploaded a new change for review.
https://gerrit.wikimedia.org/r/57244
Change subject: Convert AnnotationFactory and MetaItemFactory to
NamedClassFactories
......................................................................
Convert AnnotationFactory and MetaItemFactory to NamedClassFactories
Change-Id: Ic6e3a336050a335c88ef41735c0f4e470c5b75b6
---
M modules/ve/dm/ve.dm.AnnotationFactory.js
M modules/ve/dm/ve.dm.MetaItemFactory.js
M modules/ve/dm/ve.dm.ModelRegistry.js
3 files changed, 8 insertions(+), 8 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor
refs/changes/44/57244/1
diff --git a/modules/ve/dm/ve.dm.AnnotationFactory.js
b/modules/ve/dm/ve.dm.AnnotationFactory.js
index 9918065..b035fda 100644
--- a/modules/ve/dm/ve.dm.AnnotationFactory.js
+++ b/modules/ve/dm/ve.dm.AnnotationFactory.js
@@ -9,17 +9,17 @@
* DataModel annotation factory.
*
* @class
- * @extends ve.Factory
+ * @extends ve.NamedClassFactory
* @constructor
*/
ve.dm.AnnotationFactory = function VeDmAnnotationFactory() {
// Parent constructor
- ve.Factory.call( this );
+ ve.NamedClassFactory.call( this );
};
/* Inheritance */
-ve.inheritClass( ve.dm.AnnotationFactory, ve.Factory );
+ve.inheritClass( ve.dm.AnnotationFactory, ve.NamedClassFactory );
/* Initialization */
diff --git a/modules/ve/dm/ve.dm.MetaItemFactory.js
b/modules/ve/dm/ve.dm.MetaItemFactory.js
index 1ebc773..04aae66 100644
--- a/modules/ve/dm/ve.dm.MetaItemFactory.js
+++ b/modules/ve/dm/ve.dm.MetaItemFactory.js
@@ -9,17 +9,17 @@
* DataModel meta item factory.
*
* @class
- * @extends ve.Factory
+ * @extends ve.NamedClassFactory
* @constructor
*/
ve.dm.MetaItemFactory = function VeDmMetaItemFactory() {
// Parent constructor
- ve.Factory.call( this );
+ ve.NamedClassFactory.call( this );
};
/* Inheritance */
-ve.inheritClass( ve.dm.MetaItemFactory, ve.Factory );
+ve.inheritClass( ve.dm.MetaItemFactory, ve.NamedClassFactory );
/* Methods */
diff --git a/modules/ve/dm/ve.dm.ModelRegistry.js
b/modules/ve/dm/ve.dm.ModelRegistry.js
index f82aa00..30d89f4 100644
--- a/modules/ve/dm/ve.dm.ModelRegistry.js
+++ b/modules/ve/dm/ve.dm.ModelRegistry.js
@@ -80,11 +80,11 @@
// Register the model with the right factory
if ( constructor.prototype instanceof ve.dm.Annotation ) {
- ve.dm.annotationFactory.register( name, constructor );
+ ve.dm.annotationFactory.register( constructor );
} else if ( constructor.prototype instanceof ve.dm.Node ) {
ve.dm.nodeFactory.register( constructor );
} else if ( constructor.prototype instanceof ve.dm.MetaItem ) {
- ve.dm.metaItemFactory.register( name, constructor );
+ ve.dm.metaItemFactory.register( constructor );
} else {
throw new Error( 'Models must be subclasses of
ve.dm.Annotation, ve.dm.Node or ve.dm.MetaItem' );
}
--
To view, visit https://gerrit.wikimedia.org/r/57244
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic6e3a336050a335c88ef41735c0f4e470c5b75b6
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Catrope <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
