Fdans has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/395537 )
Change subject: build: drop PhantomJS, use Chrome/Firefox
......................................................................
build: drop PhantomJS, use Chrome/Firefox
'npm test' runs PhantomJS which uses the Webkit engine. It is quite
outdated and offer little speed benefits compared to Chrome or Firefox.
Switch 'npm test' to run Karma with Chrome and Firefox.
Add karma-firefox-launcher
Remove karma-phantomjs-launcher
Wikimedia Jenkins will run it as:
CHROME_BIN=/usr/bin/chromium npm test
Result:
Chrome 62.0.3202: Executed 71 of 71 SUCCESS (0.242 secs / 0.296 secs)
Firefox 52.0.0: Executed 71 of 71 SUCCESS (0.491 secs / 0.546 secs)
'npm testDev' is left untouched and still runs whatever browser is
defined in karma.conf (which is 'Chrome').
Change-Id: Idb02dd8afb1b2f20f7affb1e67fbf8b8d37700d7
---
M package.json
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
jenkins-bot: Verified
Fdans: Verified; Looks good to me, approved
diff --git a/package.json b/package.json
index d608024..9138996 100644
--- a/package.json
+++ b/package.json
@@ -4,7 +4,7 @@
"description": "A front end for Wikimedia project statistics. This is a
new version implemented with Vue and Semantic UI.",
"main": "index.js",
"scripts": {
- "test": "./node_modules/karma/bin/karma start --single-run --browsers
PhantomJS",
+ "test": "./node_modules/karma/bin/karma start --single-run --browsers
Chrome,Firefox",
"testDev": "./node_modules/karma/bin/karma start",
"build": "./node_modules/webpack/bin/webpack.js --config
webpack/prod.config.js",
"start": "NODE_ENV=development webpack-dev-server --config
webpack/dev.config.js",
@@ -39,9 +39,9 @@
"jasmine-core": "^2.6.2",
"karma": "^1.7.0",
"karma-chrome-launcher": "^2.1.1",
+ "karma-firefox-launcher": "^1.0.1",
"karma-jasmine": "^1.1.0",
"karma-jasmine-ajax": "^0.1.13",
- "karma-phantomjs-launcher": "^1.0.4",
"karma-webpack": "^2.0.3",
"style-loader": "^0.18.1",
"string-replace-loader": "^1.3.0",
--
To view, visit https://gerrit.wikimedia.org/r/395537
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Idb02dd8afb1b2f20f7affb1e67fbf8b8d37700d7
Gerrit-PatchSet: 1
Gerrit-Project: analytics/wikistats2
Gerrit-Branch: master
Gerrit-Owner: Hashar <[email protected]>
Gerrit-Reviewer: Fdans <[email protected]>
Gerrit-Reviewer: Hashar <[email protected]>
Gerrit-Reviewer: Jdrewniak <[email protected]>
Gerrit-Reviewer: Milimetric <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
