Ladsgroup has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/397586 )

Change subject: Clean up the model lookup code for ApiHooksHandler a bit
......................................................................

Clean up the model lookup code for ApiHooksHandler a bit

Change-Id: I26daf602918dcca347d93bd559e95a35ed5a8732
---
M includes/Hooks/ApiHooksHandler.php
1 file changed, 5 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/ORES 
refs/changes/86/397586/1

diff --git a/includes/Hooks/ApiHooksHandler.php 
b/includes/Hooks/ApiHooksHandler.php
index 3369e3c..8ea1ca3 100644
--- a/includes/Hooks/ApiHooksHandler.php
+++ b/includes/Hooks/ApiHooksHandler.php
@@ -261,10 +261,12 @@
 
                $modelData = MediaWikiServices::getInstance()->getService( 
'ORESModelLookup' )
                        ->getModels();
-               $modelIds = [];
+
+               $models = [];
                foreach ( $modelData as $modelName => $modelDatum ) {
-                       $modelIds[] = $modelDatum['id'];
+                       $models[$modelDatum['id']] = $modelName;
                }
+
                // Load cached score data
                $dbr = \wfGetDB( DB_REPLICA );
                $res2 = $dbr->select(
@@ -272,7 +274,7 @@
                        [ 'oresc_rev', 'oresc_class', 'oresc_probability' ],
                        [
                                'oresc_rev' => $revids,
-                               'oresc_model' => $modelIds,
+                               'oresc_model' => array_keys( $models ),
                        ],
                        __METHOD__
                );

-- 
To view, visit https://gerrit.wikimedia.org/r/397586
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I26daf602918dcca347d93bd559e95a35ed5a8732
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/ORES
Gerrit-Branch: master
Gerrit-Owner: Ladsgroup <ladsgr...@gmail.com>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to