Mholloway has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/397622 )
Change subject: Don't return 204 for main pages
......................................................................
Don't return 204 for main pages
I believe this was added based on a misreading of the earlier patch for
handling redirects. Instead, main pages should be handled in the general
case of pages with no lead intros, which is to return a valid summary
object with empty extract fields.
This is subject to confirmation from Reading Web but I'm putting in the
patch now since it's nearly deployment time.
Bug: T177431
Change-Id: I3b5448369bd07580842188305d2c246b9f78b111
---
M lib/mobile-util.js
1 file changed, 0 insertions(+), 5 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/services/mobileapps
refs/changes/22/397622/1
diff --git a/lib/mobile-util.js b/lib/mobile-util.js
index acbccc8..91649f7 100644
--- a/lib/mobile-util.js
+++ b/lib/mobile-util.js
@@ -200,7 +200,6 @@
const meta = pageData.meta;
const isContentModelWikitext = meta.contentmodel === 'wikitext';
const isWhiteListedNamespace =
mUtil.SUMMARY_NS_WHITELIST.includes(meta.ns);
- const isMainPage = meta.mainpage;
const isRedirect = meta.redirect;
if (!isContentModelWikitext) {
@@ -208,10 +207,6 @@
}
if (!isWhiteListedNamespace) {
- return { code: 204 };
- }
-
- if (isMainPage) {
return { code: 204 };
}
--
To view, visit https://gerrit.wikimedia.org/r/397622
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3b5448369bd07580842188305d2c246b9f78b111
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/services/mobileapps
Gerrit-Branch: master
Gerrit-Owner: Mholloway <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
