Ottomata has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/397629 )
Change subject: Fix superset lookup_password to work with sqla uris
......................................................................
Fix superset lookup_password to work with sqla uris
Bug: T166689
Change-Id: Ib861ea89d9411880f09b83f67b48a319269bacab
---
M modules/superset/templates/superset_config.py.erb
1 file changed, 3 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/operations/puppet
refs/changes/29/397629/1
diff --git a/modules/superset/templates/superset_config.py.erb
b/modules/superset/templates/superset_config.py.erb
index eb62719..7cf7fea 100644
--- a/modules/superset/templates/superset_config.py.erb
+++ b/modules/superset/templates/superset_config.py.erb
@@ -56,8 +56,9 @@
'<%= uri %>': '<%= @password_mapping[uri] %>',
<% end -%>
}
-def lookup_password(uri):
- return password_mapping.get(uri, None)
+# self is needed because:
https://github.com/apache/incubator-superset/issues/4043
+def lookup_password(self, uri):
+ return password_mapping.get(str(uri), None)
SQLALCHEMY_CUSTOM_PASSWORD_STORE = lookup_password
<% end -%>
--
To view, visit https://gerrit.wikimedia.org/r/397629
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib861ea89d9411880f09b83f67b48a319269bacab
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Ottomata <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
