jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/395514 )
Change subject: Update RuboCop Ruby gem
......................................................................
Update RuboCop Ruby gem
Bug: T180878
Change-Id: I904e947d7044b259f29f584b568ab2cb689bd5a4
---
A .rubocop_todo.yml
M Gemfile
M Gemfile.lock
3 files changed, 123 insertions(+), 15 deletions(-)
Approvals:
jenkins-bot: Verified
Jforrester: Looks good to me, approved
diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml
new file mode 100644
index 0000000..845059a
--- /dev/null
+++ b/.rubocop_todo.yml
@@ -0,0 +1,103 @@
+# This configuration was generated by
+# `rubocop --auto-gen-config`
+# on 2017-12-06 12:25:18 +0000 using RuboCop version 0.51.0.
+# The point is for the user to remove these configuration records
+# one by one as the offenses are removed from the code base.
+# Note that changes in the inspected code, or installation of new
+# versions of RuboCop, may require this file to be generated again.
+
+# Offense count: 1
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, SupportedStyles.
+# SupportedStyles: auto_detection, squiggly, active_support, powerpack,
unindent
+Layout/IndentHeredoc:
+ Exclude:
+ - 'tests/browser/features/step_definitions/create_page_api_steps.rb'
+
+# Offense count: 7
+Lint/AmbiguousRegexpLiteral:
+ Exclude:
+ - 'tests/browser/features/step_definitions/common_article_steps.rb'
+ - 'tests/browser/features/step_definitions/common_steps.rb'
+ - 'tests/browser/features/step_definitions/language_icon_steps.rb'
+ - 'tests/browser/features/step_definitions/language_steps.rb'
+ - 'tests/browser/features/step_definitions/notification_steps.rb'
+
+# Offense count: 1
+# Configuration parameters: CountComments.
+Metrics/ClassLength:
+ Max: 131
+
+# Offense count: 42
+# Configuration parameters: AllowHeredoc, AllowURI, URISchemes,
IgnoreCopDirectives, IgnoredPatterns.
+# URISchemes: http, https
+Metrics/LineLength:
+ Max: 156
+
+# Offense count: 1
+# Configuration parameters: EnforcedStyle, SupportedStyles.
+# SupportedStyles: lowercase, uppercase
+Naming/HeredocDelimiterCase:
+ Exclude:
+ - 'tests/browser/features/step_definitions/create_page_api_steps.rb'
+
+# Offense count: 1
+# Configuration parameters: Blacklist.
+# Blacklist: END, (?-mix:EO[A-Z]{1})
+Naming/HeredocDelimiterNaming:
+ Exclude:
+ - 'tests/browser/features/step_definitions/create_page_api_steps.rb'
+
+# Offense count: 2
+# Cop supports --auto-correct.
+Performance/StringReplacement:
+ Exclude:
+ - 'tests/browser/features/step_definitions/common_steps.rb'
+
+# Offense count: 13
+Style/Documentation:
+ Exclude:
+ - 'spec/**/*'
+ - 'test/**/*'
+ - 'tests/browser/features/support/pages/article_page.rb'
+ - 'tests/browser/features/support/pages/create_article_page.rb'
+ - 'tests/browser/features/support/pages/diff_page.rb'
+ - 'tests/browser/features/support/pages/language_page.rb'
+ - 'tests/browser/features/support/pages/main_page.rb'
+ - 'tests/browser/features/support/pages/notification_page.rb'
+ - 'tests/browser/features/support/pages/page.rb'
+ - 'tests/browser/features/support/pages/special_history_page.rb'
+ - 'tests/browser/features/support/pages/special_mobilediff_page.rb'
+ - 'tests/browser/features/support/pages/special_search_page.rb'
+ - 'tests/browser/features/support/pages/special_userlogin_page.rb'
+ - 'tests/browser/features/support/pages/user_page.rb'
+
+# Offense count: 1
+Style/MixinUsage:
+ Exclude:
+ - 'tests/browser/features/support/pages/special_history_page.rb'
+
+# Offense count: 1
+# Cop supports --auto-correct.
+# Configuration parameters: Whitelist.
+# Whitelist: be, be_a, be_an, be_between, be_falsey, be_kind_of,
be_instance_of, be_truthy, be_within, eq, eql, end_with, include, match,
raise_error, respond_to, start_with
+Style/NestedParenthesizedCalls:
+ Exclude:
+ - 'tests/browser/features/step_definitions/search_steps.rb'
+
+# Offense count: 3
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, SupportedStyles, AllowInnerSlashes.
+# SupportedStyles: slashes, percent_r, mixed
+Style/RegexpLiteral:
+ Exclude:
+ - 'tests/browser/features/step_definitions/search_steps.rb'
+ - 'tests/browser/features/support/pages/user_page.rb'
+
+# Offense count: 1
+# Cop supports --auto-correct.
+# Configuration parameters: IgnoredMethods.
+# IgnoredMethods: respond_to, define_method
+Style/SymbolProc:
+ Exclude:
+ - 'tests/browser/features/support/hooks.rb'
diff --git a/Gemfile b/Gemfile
index 144b926..18753bc 100644
--- a/Gemfile
+++ b/Gemfile
@@ -4,4 +4,4 @@
gem 'mediawiki_selenium', '~> 1.7', '>= 1.7.3'
gem 'page-object', '1.1.0'
gem 'rake', '~> 10.4', '>= 10.4.2'
-gem 'rubocop', '~> 0.29.1', require: false
+gem 'rubocop', '~> 0.51.0', require: false
diff --git a/Gemfile.lock b/Gemfile.lock
index 0b46fb7..4f96163 100644
--- a/Gemfile.lock
+++ b/Gemfile.lock
@@ -1,9 +1,7 @@
GEM
remote: https://rubygems.org/
specs:
- ast (2.2.0)
- astrolabe (1.3.1)
- parser (~> 2.2)
+ ast (2.3.0)
builder (3.2.2)
childprocess (0.5.9)
ffi (~> 1.0, >= 1.0.11)
@@ -64,10 +62,12 @@
watir-webdriver (>= 0.6.11)
page_navigation (0.9)
data_magic (>= 0.14)
- parser (2.3.0.7)
- ast (~> 2.2)
+ parallel (1.12.0)
+ parser (2.4.0.2)
+ ast (~> 2.3)
powerpack (0.1.1)
- rainbow (2.1.0)
+ rainbow (2.2.2)
+ rake
rake (10.5.0)
rest-client (1.8.0)
http-cookie (>= 1.0.2, < 2.0)
@@ -76,14 +76,15 @@
rspec-core (2.99.2)
rspec-expectations (2.99.2)
diff-lcs (>= 1.1.3, < 2.0)
- rubocop (0.29.1)
- astrolabe (~> 1.3)
- parser (>= 2.2.0.1, < 3.0)
+ rubocop (0.51.0)
+ parallel (~> 1.10)
+ parser (>= 2.3.3.1, < 3.0)
powerpack (~> 0.1)
- rainbow (>= 1.99.1, < 3.0)
- ruby-progressbar (~> 1.4)
- ruby-progressbar (1.8.0)
- rubyzip (1.2.0)
+ rainbow (>= 2.2.2, < 3.0)
+ ruby-progressbar (~> 1.7)
+ unicode-display_width (~> 1.0, >= 1.0.1)
+ ruby-progressbar (1.9.0)
+ rubyzip (1.2.1)
selenium-webdriver (2.53.0)
childprocess (~> 0.5)
rubyzip (~> 1.0)
@@ -93,6 +94,7 @@
unf (0.1.4)
unf_ext
unf_ext (0.0.7.2)
+ unicode-display_width (1.3.0)
watir-webdriver (0.9.1)
selenium-webdriver (>= 2.46.2)
websocket (1.2.3)
@@ -106,4 +108,7 @@
mediawiki_selenium (~> 1.7, >= 1.7.3)
page-object (= 1.1.0)
rake (~> 10.4, >= 10.4.2)
- rubocop (~> 0.29.1)
+ rubocop (~> 0.51.0)
+
+BUNDLED WITH
+ 1.16.0
--
To view, visit https://gerrit.wikimedia.org/r/395514
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I904e947d7044b259f29f584b568ab2cb689bd5a4
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/skins/MinervaNeue
Gerrit-Branch: master
Gerrit-Owner: Zfilipin <zfili...@wikimedia.org>
Gerrit-Reviewer: Addshore <addshorew...@gmail.com>
Gerrit-Reviewer: Hashar <has...@free.fr>
Gerrit-Reviewer: Jdlrobson <jrob...@wikimedia.org>
Gerrit-Reviewer: Jforrester <jforres...@wikimedia.org>
Gerrit-Reviewer: Phuedx <samsm...@wikimedia.org>
Gerrit-Reviewer: Pmiazga <pmia...@wikimedia.org>
Gerrit-Reviewer: Zfilipin <zfili...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
