jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/396917 )
Change subject: [bugfix] Catch AttributeError and raise the ValueError
......................................................................
[bugfix] Catch AttributeError and raise the ValueError
Bug: T181913
Change-Id: Id03f32e8dc422a22f9998030836da5be8d25af52
---
M pywikibot/proofreadpage.py
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Mpaa: Looks good to me, approved
jenkins-bot: Verified
Zoranzoki21: Looks good to me, but someone else must approve
diff --git a/pywikibot/proofreadpage.py b/pywikibot/proofreadpage.py
index f4e6a08..2919514 100644
--- a/pywikibot/proofreadpage.py
+++ b/pywikibot/proofreadpage.py
@@ -532,12 +532,12 @@
soup = Soup(response.content)
try:
- # None if nothing is found by .find()
self._url_image = soup.find(class_='prp-page-image')
+ # if None raises AttributeError
self._url_image = self._url_image.find('img')
# if None raises TypeError.
self._url_image = self._url_image['src']
- except TypeError:
+ except (TypeError, AttributeError):
raise ValueError('No prp-page-image src found for %s.' % self)
else:
self._url_image = 'https:' + self._url_image
--
To view, visit https://gerrit.wikimedia.org/r/396917
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id03f32e8dc422a22f9998030836da5be8d25af52
Gerrit-PatchSet: 2
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Owner: Xqt <i...@gno.de>
Gerrit-Reviewer: Dalba <dalba.w...@gmail.com>
Gerrit-Reviewer: John Vandenberg <jay...@gmail.com>
Gerrit-Reviewer: Mpaa <mpaa.w...@gmail.com>
Gerrit-Reviewer: Zoranzoki21 <zorandori4...@gmail.com>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
