jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/385959 )
Change subject: Fixing spacing in footer license
......................................................................
Fixing spacing in footer license
The default english version has a hard-coded full-stop after the
"Creative Commons Attribution-ShareAlike License." link, whereas some
translations don't have a full-stop, causing the license and "Terms
of Service" link to read as one.
This replaces the full-stop with a bullet character and adds some
padding before and after the bullet.
Bug: T178744
Change-Id: Iea25b07f20922eba0c36bb90e74bc4212c10f84b
---
M dev/wikipedia.org/assets/postcss/_footer.css
M dev/wikipedia.org/templates/site-license.handlebars
2 files changed, 14 insertions(+), 2 deletions(-)
Approvals:
Debt: Looks good to me, approved
jenkins-bot: Verified
diff --git a/dev/wikipedia.org/assets/postcss/_footer.css
b/dev/wikipedia.org/assets/postcss/_footer.css
index ed3cea9..78df128 100644
--- a/dev/wikipedia.org/assets/postcss/_footer.css
+++ b/dev/wikipedia.org/assets/postcss/_footer.css
@@ -52,6 +52,18 @@
text-align: center;
}
+.site-license small:after {
+ content: '\2022'; /* bullet character */
+ display: inline-block;
+ font-size: 1.3rem;
+ line-height: inherit;
+ margin-left: 0.8rem; /* margins differ to account for inline-block
white-space */
+ margin-right: 0.5rem;
+}
+.site-license small:last-child:after {
+ display: none;
+}
+
@media screen and ( max-width: 768px ) {
.footer {
diff --git a/dev/wikipedia.org/templates/site-license.handlebars
b/dev/wikipedia.org/templates/site-license.handlebars
index 4ef53e5..0fcae3a 100644
--- a/dev/wikipedia.org/templates/site-license.handlebars
+++ b/dev/wikipedia.org/templates/site-license.handlebars
@@ -1,5 +1,5 @@
<p class="site-license">
- <small class="jsl10n" data-jsl10n="license">This page is available under
the <a href="//creativecommons.org/licenses/by-sa/3.0/">Creative Commons
Attribution-ShareAlike License</a>.</small>
- <small class="jsl10n" data-jsl10n="terms" ><a
href="//meta.wikimedia.org/wiki/Terms_of_Use">Terms of Use </a></small> •
+ <small class="jsl10n" data-jsl10n="license">This page is available under
the <a href="https://creativecommons.org/licenses/by-sa/3.0/";>Creative Commons
Attribution-ShareAlike License</a></small>
+ <small class="jsl10n" data-jsl10n="terms" ><a
href="//meta.wikimedia.org/wiki/Terms_of_Use">Terms of Use</a></small>
<small class="jsl10n" data-jsl10n="Privacy Policy"><a
href="//meta.wikimedia.org/wiki/Privacy_policy">Privacy Policy</a></small>
</p>
--
To view, visit https://gerrit.wikimedia.org/r/385959
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iea25b07f20922eba0c36bb90e74bc4212c10f84b
Gerrit-PatchSet: 3
Gerrit-Project: wikimedia/portals
Gerrit-Branch: master
Gerrit-Owner: Jdrewniak <[email protected]>
Gerrit-Reviewer: Debt <[email protected]>
Gerrit-Reviewer: Mxn <[email protected]>
Gerrit-Reviewer: VolkerE <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
