jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/376185 )
Change subject: [BREAKING CHANGE] SelectWidget: Remove getRelativeSelectableItem
......................................................................
[BREAKING CHANGE] SelectWidget: Remove getRelativeSelectableItem
Follows-up on I7b556fcae7ac4c4a6508d931d7a5d9ee1e7c59e5
Bug: T76630
Change-Id: I68bd2899cb2a8d6f2ff0dcc167028595a5996c60
---
M src/widgets/SelectWidget.js
1 file changed, 0 insertions(+), 18 deletions(-)
Approvals:
jenkins-bot: Verified
VolkerE: Looks good to me, approved
Jforrester: Looks good to me, but someone else must approve
diff --git a/src/widgets/SelectWidget.js b/src/widgets/SelectWidget.js
index 32742c4..c115712 100644
--- a/src/widgets/SelectWidget.js
+++ b/src/widgets/SelectWidget.js
@@ -807,24 +807,6 @@
};
/**
- * Get an option by its position relative to the specified item (or to the
start of the option array,
- * if item is `null`). The direction in which to search through the option
array is specified with a
- * number: -1 for reverse (the default) or 1 for forward. The method will
return an option, or
- * `null` if there are no options in the array.
- *
- * @deprecated 0.23.1 Use {@link #findRelativeSelectableItem} instead
- * @param {OO.ui.OptionWidget|null} item Item to describe the start position,
or `null` to start at the beginning of the array.
- * @param {number} direction Direction to move in: -1 to move backward, 1 to
move forward
- * @param {Function} [filter] Only consider items for which this function
returns
- * true. Function takes an OO.ui.OptionWidget and returns a boolean.
- * @return {OO.ui.OptionWidget|null} Item at position, `null` if there are no
items in the select
- */
-OO.ui.SelectWidget.prototype.getRelativeSelectableItem = function ( item,
direction, filter ) {
- OO.ui.warnDeprecation( 'SelectWidget#getRelativeSelectableItem:
Deprecated function. Use findRelativeSelectableItem instead. See T76630.' );
- return this.findRelativeSelectableItem( item, direction, filter );
-};
-
-/**
* Find the next selectable item or `null` if there are no selectable items.
* Disabled options and menu-section markers and breaks are not selectable.
*
--
To view, visit https://gerrit.wikimedia.org/r/376185
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I68bd2899cb2a8d6f2ff0dcc167028595a5996c60
Gerrit-PatchSet: 2
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: Prtksxna <[email protected]>
Gerrit-Reviewer: Bartosz Dziewoński <[email protected]>
Gerrit-Reviewer: Jforrester <[email protected]>
Gerrit-Reviewer: VolkerE <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
