BearND has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/397928 )

Change subject: Fix onthisday with section tags
......................................................................

Fix onthisday with section tags

Onthisday was looking for direct children of body to look for the
elements, which is bad with the section tags deployed.

Change-Id: Iabc1e162ac106f0b5ff5ab6ca395b60cb9819201
---
M lib/feed/on-this-day.languages.js
1 file changed, 8 insertions(+), 8 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/services/mobileapps 
refs/changes/28/397928/1

diff --git a/lib/feed/on-this-day.languages.js 
b/lib/feed/on-this-day.languages.js
index 3df2f41..6da6dc2 100644
--- a/lib/feed/on-this-day.languages.js
+++ b/lib/feed/on-this-day.languages.js
@@ -23,7 +23,7 @@
             // 
https://en.wikipedia.org/api/rest_v1/page/html/Wikipedia:Selected_anniversaries%2FMay_22
             nameFormatter : (monthName, monthNumber, dayNumber) =>
                 `Wikipedia:Selected_anniversaries/${monthName}_${dayNumber}`,
-            listElementSelector: 'body > ul li'
+            listElementSelector: 'section > ul li'
         },
         yearListElementRegEx :
           // eslint-disable-next-line max-len
@@ -55,7 +55,7 @@
             // 
https://de.wikipedia.org/api/rest_v1/page/html/Wikipedia:Hauptseite%2FJahrestage%2FMai%2F22
             nameFormatter : (monthName, monthNumber, dayNumber) =>
                 `Wikipedia:Hauptseite/Jahrestage/${monthName}/${dayNumber}`,
-            listElementSelector: 'body > ul li'
+            listElementSelector: 'section > ul li'
         },
         yearListElementRegEx :
           new 
RegExp(String.raw`^\s*(\d+)\s*(v\.\s*Chr\.)?\s*(?::|[${dashChars}])\s*(.*\S.*)`,
 'i'),
@@ -93,7 +93,7 @@
                 }
                 return `Wikipédia:Éphéméride/${dayNumber}_${monthName}`;
             },
-            listElementSelector: 'body > ul li'
+            listElementSelector: 'section > ul li'
         },
         yearListElementRegEx :
           // eslint-disable-next-line max-len
@@ -120,7 +120,7 @@
         selectedPage : {
             // https://sv.wikipedia.org/api/rest_v1/page/html/Mall:22_maj
             nameFormatter : (monthName, monthNumber, dayNumber) => 
`Mall:${dayNumber}_${monthName}`,
-            listElementSelector: 'body > ul li'
+            listElementSelector: 'section > ul li'
         },
         yearListElementRegEx :
           new 
RegExp(String.raw`^\s*(\d+)\s*(f\.\s*Kr\.)?\s*[${dashChars}]\s*(.*\S.*)`, 'i'),
@@ -147,7 +147,7 @@
             // 
https://pt.wikipedia.org/api/rest_v1/page/html/Wikipédia:Efemérides%2F22_de_maio
             nameFormatter : (monthName, monthNumber, dayNumber) =>
                 `Wikipédia:Efemérides/${dayNumber}_${monthName}`,
-            listElementSelector: 'body > ul li'
+            listElementSelector: 'section > ul li'
         },
         yearListElementRegEx :
           new 
RegExp(String.raw`^\s*(\d+)\s*(a\.\s*C\.)?\s*[${dashChars}]\s*(.*\S.*)`, 'i'),
@@ -182,7 +182,7 @@
             // 
https://ru.wikipedia.org/api/rest_v1/page/html/Шаблон:События_дня:05-30
             nameFormatter : (monthName, monthNo, dayNo) =>
                 `Шаблон:События_дня:${monthNo < 10 ? `0${monthNo}` : 
monthNo}-${dayNo}`,
-            listElementSelector: 'body > ul li'
+            listElementSelector: 'section > ul li'
         },
         yearListElementRegEx :
           // eslint-disable-next-line max-len
@@ -210,7 +210,7 @@
             // 
https://es.wikipedia.org/api/rest_v1/page/html/Plantilla:Efemérides_-_22_de_mayo
             nameFormatter : (monthName, monthNumber, dayNumber) =>
                 `Plantilla:Efemérides - ${dayNumber}_${monthName}`,
-            listElementSelector: 'body > ul li'
+            listElementSelector: 'section > ul li'
         },
         yearListElementRegEx :
           new 
RegExp(String.raw`^\s*(\d+)\s*(a\.\s*C\.)?\s*\.*[:${dashChars}]\s*(.*\S.*)`, 
'i'),
@@ -238,7 +238,7 @@
             // 
https://ar.wikipedia.org/api/rest_v1/page/html/%D9%88%D9%8A%D9%83%D9%8A%D8%A8%D9%8A%D8%AF%D9%8A%D8%A7%3A%D9%81%D9%8A_%D9%87%D8%B0%D8%A7_%D8%A7%D9%84%D9%8A%D9%88%D9%85%2F22_%D9%85%D8%A7%D9%8A%D9%88
             nameFormatter : (monthName, monthNumber, dayNumber) =>
                 `ويكيبيديا:في_هذا_اليوم/${dayNumber}_${monthName}`,
-            listElementSelector: 'body > ul li'
+            listElementSelector: 'section > ul li'
         },
         yearListElementRegEx :
           new 
RegExp(String.raw`^\s*(\d+)\s*(ق.م)?\s*[${dashChars}]\s*(.*\S.*)`, 'i'),

-- 
To view, visit https://gerrit.wikimedia.org/r/397928
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iabc1e162ac106f0b5ff5ab6ca395b60cb9819201
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/services/mobileapps
Gerrit-Branch: master
Gerrit-Owner: BearND <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to