Lucas Werkmeister (WMDE) has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/398081 )

Change subject: Render autocomment parameters as plain text
......................................................................

Render autocomment parameters as plain text

None of the existing messages seem to use wikitext in the parameters:

- wikibase-entity-summary-wbcreateredirect,
  wikibase-entity-summary-wbmergeitems-from and
  wikibase-entity-summary-wbmergeitems-to only insert the plain page
  title for the mentioned page, not a link.
- wikibase-entity-summary-undo and wikibase-entity-summary-restore
  create a link to Special:Contributions inside the message text itself,
  the parameter is just the plain user name.
- All other message parameters appear to be language codes, wiki codes
  or counts, all of which should be plain text.

Bug: T182800
Change-Id: Ia0e517c004fa9b045c64e8a8d65d11688d21eeab
---
M lib/includes/Formatters/AutoCommentFormatter.php
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase 
refs/changes/81/398081/1

diff --git a/lib/includes/Formatters/AutoCommentFormatter.php 
b/lib/includes/Formatters/AutoCommentFormatter.php
index 0c77d87..b57ab55 100644
--- a/lib/includes/Formatters/AutoCommentFormatter.php
+++ b/lib/includes/Formatters/AutoCommentFormatter.php
@@ -100,7 +100,7 @@
                }
 
                // render the autocomment
-               $auto = $msg->params( $args )->parse();
+               $auto = $msg->plaintextParams( $args )->parse();
                return $auto;
        }
 

-- 
To view, visit https://gerrit.wikimedia.org/r/398081
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia0e517c004fa9b045c64e8a8d65d11688d21eeab
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Lucas Werkmeister (WMDE) <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to