jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/398084 )
Change subject: trackSubscriber: data isn't required
......................................................................
trackSubscriber: data isn't required
Editor-fixing caused errors on some events which don't pass data in.
Introduced in 8f612fbe64.
Change-Id: I5c9471e6ffe4cdda0bf5455c80ef70251690e20f
---
M modules/ve-mw/init/ve.init.mw.trackSubscriber.js
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
jenkins-bot: Verified
Jforrester: Looks good to me, approved
diff --git a/modules/ve-mw/init/ve.init.mw.trackSubscriber.js
b/modules/ve-mw/init/ve.init.mw.trackSubscriber.js
index 29b75cb..2caa31d 100644
--- a/modules/ve-mw/init/ve.init.mw.trackSubscriber.js
+++ b/modules/ve-mw/init/ve.init.mw.trackSubscriber.js
@@ -95,7 +95,7 @@
}
// Convert mode=source/visual to editor name
- if ( data.mode ) {
+ if ( data && data.mode ) {
data.editor = data.mode === 'source' ? 'wikitext-2017'
: 'visualeditor';
delete data.mode;
}
--
To view, visit https://gerrit.wikimedia.org/r/398084
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5c9471e6ffe4cdda0bf5455c80ef70251690e20f
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: DLynch <[email protected]>
Gerrit-Reviewer: Esanders <[email protected]>
Gerrit-Reviewer: Jforrester <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
