jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/396027 )
Change subject: Track which namespaces edit conflicts are resolved in
......................................................................
Track which namespaces edit conflicts are resolved in
This is similar to the tracking of the occourance of
edit conflicts but tracks the resolution of the conflicts.
Bug: T182011
Change-Id: I9a0c05dc921946fb6e0580b56b663783ca0b1b6e
---
M includes/editpage/TextConflictHelper.php
1 file changed, 9 insertions(+), 0 deletions(-)
Approvals:
Legoktm: Looks good to me, approved
WMDE-Fisch: Looks good to me, but someone else must approve
jenkins-bot: Verified
diff --git a/includes/editpage/TextConflictHelper.php
b/includes/editpage/TextConflictHelper.php
index b1eaa4b..6e7e7ee 100644
--- a/includes/editpage/TextConflictHelper.php
+++ b/includes/editpage/TextConflictHelper.php
@@ -140,6 +140,15 @@
*/
public function incrementResolvedStats() {
$this->stats->increment( 'edit.failures.conflict.resolved' );
+ // Only include 'standard' namespaces to avoid creating unknown
numbers of statsd metrics
+ if (
+ $this->title->getNamespace() >= NS_MAIN &&
+ $this->title->getNamespace() <= NS_CATEGORY_TALK
+ ) {
+ $this->stats->increment(
+
'edit.failures.conflict.resolved.byNamespaceId.' . $this->title->getNamespace()
+ );
+ }
}
/**
--
To view, visit https://gerrit.wikimedia.org/r/396027
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9a0c05dc921946fb6e0580b56b663783ca0b1b6e
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Addshore <addshorew...@gmail.com>
Gerrit-Reviewer: Legoktm <lego...@member.fsf.org>
Gerrit-Reviewer: Thiemo Mättig (WMDE) <thiemo.kr...@wikimedia.de>
Gerrit-Reviewer: WMDE-Fisch <christoph.jau...@wikimedia.de>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
