Bartosz Dziewoński has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/398194 )
Change subject: DropdownWidget: Remove stray use of this.$() ...................................................................... DropdownWidget: Remove stray use of this.$() this.$() is deprecated since c38a54272fd7df5ef7aeea4d131d1716ac986a9d, which also removed all uses of it in this repo. This instance was erroneously reintroduced in fe8e2f5a485727e2c8c24008ca096c39a6f47abd, probably due to a carelessly resolved merge conflict. Change-Id: Ief573eea8b5ec91dc5bb424545458a798329d527 --- M src/widgets/DropdownWidget.js 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/oojs/ui refs/changes/94/398194/1 diff --git a/src/widgets/DropdownWidget.js b/src/widgets/DropdownWidget.js index 09a157f..f81fb31 100644 --- a/src/widgets/DropdownWidget.js +++ b/src/widgets/DropdownWidget.js @@ -62,7 +62,7 @@ OO.ui.DropdownWidget.parent.call( this, config ); // Properties (must be set before TabIndexedElement constructor call) - this.$handle = this.$( '<span>' ); + this.$handle = $( '<span>' ); this.$overlay = config.$overlay || this.$element; // Mixin constructors -- To view, visit https://gerrit.wikimedia.org/r/398194 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ief573eea8b5ec91dc5bb424545458a798329d527 Gerrit-PatchSet: 1 Gerrit-Project: oojs/ui Gerrit-Branch: master Gerrit-Owner: Bartosz Dziewoński <matma....@gmail.com> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits