jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/396648 )
Change subject: Rename classes to match files
......................................................................
Rename classes to match files
Change-Id: I9cd94a6050b96bdb40051c10eb12ce81d40887ee
---
M .phpcs.xml
M ProofreadPage.body.php
M SpecialPagesWithoutScans.php
M SpecialProofreadPages.php
M extension.json
M tests/phpunit/Pagination/PageNumberTest.php
6 files changed, 12 insertions(+), 10 deletions(-)
Approvals:
jenkins-bot: Verified
Thiemo Mättig (WMDE): Looks good to me, but someone else must approve
Tpt: Looks good to me, approved
diff --git a/.phpcs.xml b/.phpcs.xml
index 5186586..2855261 100644
--- a/.phpcs.xml
+++ b/.phpcs.xml
@@ -8,10 +8,12 @@
<exclude
name="MediaWiki.Commenting.FunctionComment.MissingReturn" />
<exclude
name="MediaWiki.ControlStructures.AssignmentInControlStructures.AssignmentInControlStructures"
/>
<exclude name="MediaWiki.Files.ClassMatchesFilename.NotMatch" />
- <exclude name="MediaWiki.Files.ClassMatchesFilename.WrongCase"
/>
<exclude
name="MediaWiki.VariableAnalysis.ForbiddenGlobalVariables.ForbiddenGlobal$wgTitle"
/>
<exclude
name="MediaWiki.WhiteSpace.SpaceBeforeSingleLineComment.NewLineComment"/>
</rule>
+ <rule ref="MediaWiki.Files.ClassMatchesFilename.WrongCase">
+ <exclude-pattern>*/maintenance/*</exclude-pattern>
+ </rule>
<rule ref="MediaWiki.NamingConventions.ValidGlobalName">
<properties>
<property name="ignoreList" type="array"
value="$proofreadPageNamespacesNames,$proofreadPageNamespacesAliases" />
diff --git a/ProofreadPage.body.php b/ProofreadPage.body.php
index e10c3f4..b50dea5 100644
--- a/ProofreadPage.body.php
+++ b/ProofreadPage.body.php
@@ -76,8 +76,8 @@
* @return bool
*/
public static function onwgQueryPages( &$queryPages ) {
- $queryPages[] = [ 'ProofreadPages', 'IndexPages' ];
- $queryPages[] = [ 'PagesWithoutScans', 'PagesWithoutScans' ];
+ $queryPages[] = [ 'SpecialProofreadPages', 'IndexPages' ];
+ $queryPages[] = [ 'SpecialPagesWithoutScans',
'PagesWithoutScans' ];
return true;
}
diff --git a/SpecialPagesWithoutScans.php b/SpecialPagesWithoutScans.php
index 7299bfc..ed19a56 100644
--- a/SpecialPagesWithoutScans.php
+++ b/SpecialPagesWithoutScans.php
@@ -23,7 +23,7 @@
* Special page that lists the texts that have no transclusions
* Pages in MediaWiki:Proofreadpage_notnaked_category are excluded.
*/
-class PagesWithoutScans extends QueryPage {
+class SpecialPagesWithoutScans extends QueryPage {
public function __construct( $name = 'PagesWithoutScans' ) {
parent::__construct( $name );
}
diff --git a/SpecialProofreadPages.php b/SpecialProofreadPages.php
index 1c17a0f..5675473 100644
--- a/SpecialProofreadPages.php
+++ b/SpecialProofreadPages.php
@@ -19,7 +19,7 @@
* @ingroup SpecialPage
*/
-class ProofreadPages extends QueryPage {
+class SpecialProofreadPages extends QueryPage {
protected $searchTerm, $searchList, $suppressSqlOffset, $queryOrder,
$sortAscending, $addOne;
public function __construct( $name = 'IndexPages' ) {
diff --git a/extension.json b/extension.json
index ea80d0f..2de9048 100644
--- a/extension.json
+++ b/extension.json
@@ -22,8 +22,8 @@
"pagequality-admin"
],
"SpecialPages": {
- "IndexPages": "ProofreadPages",
- "PagesWithoutScans": "PagesWithoutScans"
+ "IndexPages": "SpecialProofreadPages",
+ "PagesWithoutScans": "SpecialPagesWithoutScans"
},
"APIMetaModules": {
"proofreadinfo": "ApiQueryProofreadInfo"
@@ -90,8 +90,8 @@
"ProofreadPage\\Parser\\PagelistTagParser":
"includes/Parser/PagelistTagParser.php",
"ProofreadPage\\Parser\\PagesTagParser":
"includes/Parser/PagesTagParser.php",
"ProofreadPage\\Parser\\PagequalityTagParser":
"includes/Parser/PagequalityTagParser.php",
- "ProofreadPages": "SpecialProofreadPages.php",
- "PagesWithoutScans": "SpecialPagesWithoutScans.php",
+ "SpecialProofreadPages": "SpecialProofreadPages.php",
+ "SpecialPagesWithoutScans": "SpecialPagesWithoutScans.php",
"ApiQueryProofread": "ApiQueryProofread.php",
"ApiQueryProofreadInfo": "ApiQueryProofreadInfo.php",
"ProofreadPage\\FileProviderMock":
"tests/phpunit/FileProviderMock.php",
diff --git a/tests/phpunit/Pagination/PageNumberTest.php
b/tests/phpunit/Pagination/PageNumberTest.php
index 9cb3b60..003b96b 100644
--- a/tests/phpunit/Pagination/PageNumberTest.php
+++ b/tests/phpunit/Pagination/PageNumberTest.php
@@ -9,7 +9,7 @@
* @group ProofreadPage
* @covers \ProofreadPage\Pagination\PageNumber
*/
-class ProofreadPageNumberTest extends ProofreadPageTestCase {
+class PageNumberTest extends ProofreadPageTestCase {
public function formattedPageNumberProvider() {
return [
--
To view, visit https://gerrit.wikimedia.org/r/396648
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9cd94a6050b96bdb40051c10eb12ce81d40887ee
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/ProofreadPage
Gerrit-Branch: master
Gerrit-Owner: Umherirrender <[email protected]>
Gerrit-Reviewer: Thiemo Mättig (WMDE) <[email protected]>
Gerrit-Reviewer: Tpt <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
