Aaron Schulz has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/57333


Change subject: Cleaned up return types for getAllQueuedJobs() and 
getAllDelayedJobs().
......................................................................

Cleaned up return types for getAllQueuedJobs() and getAllDelayedJobs().

Change-Id: I305941c817dd13427d291b9265a71f9df9130f1c
---
M includes/job/JobQueue.php
1 file changed, 3 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/33/57333/1

diff --git a/includes/job/JobQueue.php b/includes/job/JobQueue.php
index 41ef443..6533abd 100644
--- a/includes/job/JobQueue.php
+++ b/includes/job/JobQueue.php
@@ -567,7 +567,7 @@
         * This does not include jobs that are currently acquired or delayed.
         * This should only be called on a queue that is no longer being popped.
         *
-        * @return Iterator|Traversable|Array
+        * @return Iterator
         * @throws MWException
         */
        abstract public function getAllQueuedJobs();
@@ -576,12 +576,12 @@
         * Get an iterator to traverse over all delayed jobs in this queue.
         * This should only be called on a queue that is no longer being popped.
         *
-        * @return Iterator|Traversable|Array
+        * @return Iterator
         * @throws MWException
         * @since 1.22
         */
        public function getAllDelayedJobs() {
-               return array(); // not implemented
+               return new ArrayIterator( array() ); // not implemented
        }
 
        /**

-- 
To view, visit https://gerrit.wikimedia.org/r/57333
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I305941c817dd13427d291b9265a71f9df9130f1c
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Aaron Schulz <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to