DLynch has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/398333 )
Change subject: ArticleTargetEvents: Track editor mode on save events
......................................................................
ArticleTargetEvents: Track editor mode on save events
Bug: T182610
Change-Id: I8b58bea8e4444478cde4c1340d13ddf97aab8f01
---
M modules/ve-mw/init/ve.init.mw.ArticleTargetEvents.js
1 file changed, 10 insertions(+), 4 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor
refs/changes/33/398333/1
diff --git a/modules/ve-mw/init/ve.init.mw.ArticleTargetEvents.js
b/modules/ve-mw/init/ve.init.mw.ArticleTargetEvents.js
index f3e9fd2..fcc2fd7 100644
--- a/modules/ve-mw/init/ve.init.mw.ArticleTargetEvents.js
+++ b/modules/ve-mw/init/ve.init.mw.ArticleTargetEvents.js
@@ -69,7 +69,9 @@
this.track( 'behavior.lastTransactionTillSaveDialogOpen', {
duration: this.timings.saveWorkflowBegin -
this.timings.lastTransaction
} );
- ve.track( 'mwedit.saveIntent' );
+ ve.track( 'mwedit.saveIntent', {
+ mode: this.target.surface ? this.target.surface.getMode() :
this.target.getDefaultMode()
+ } );
};
/**
@@ -89,7 +91,9 @@
this.track( 'behavior.saveDialogOpenTillSave', {
duration: this.timings.saveInitiated -
this.timings.saveWorkflowBegin
} );
- ve.track( 'mwedit.saveAttempt' );
+ ve.track( 'mwedit.saveAttempt', {
+ mode: this.target.surface ? this.target.surface.getMode() :
this.target.getDefaultMode()
+ } );
};
/**
@@ -104,7 +108,8 @@
this.timings.saveRetries = 0;
ve.track( 'mwedit.saveSuccess', {
timing: ve.now() - this.timings.saveInitiated + (
this.timings.serializeForCache || 0 ),
- 'page.revid': newRevId
+ 'page.revid': newRevId,
+ mode: this.target.surface ? this.target.surface.getMode() :
this.target.getDefaultMode()
} );
};
@@ -150,7 +155,8 @@
data = {
type: typeMap[ type ] || 'responseUnknown',
- timing: ve.now() - this.timings.saveInitiated + (
this.timings.serializeForCache || 0 )
+ timing: ve.now() - this.timings.saveInitiated + (
this.timings.serializeForCache || 0 ),
+ mode: this.target.surface ? this.target.surface.getMode() :
this.target.getDefaultMode()
};
if ( type === 'unknown' && failureArguments[ 0 ] ) {
data.message = failureArguments[ 0 ];
--
To view, visit https://gerrit.wikimedia.org/r/398333
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8b58bea8e4444478cde4c1340d13ddf97aab8f01
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: DLynch <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
