Subramanya Sastry has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/398418 )
Change subject: WIP: Remove false positives from multiline-table-in-list
category
......................................................................
WIP: Remove false positives from multiline-table-in-list category
Change-Id: If633fc34584bde6a7f13ba903a563026fd304272
---
M lib/wt2html/pp/handlers/linter.js
1 file changed, 10 insertions(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/services/parsoid
refs/changes/18/398418/1
diff --git a/lib/wt2html/pp/handlers/linter.js
b/lib/wt2html/pp/handlers/linter.js
index f06ad79..a1cee92 100644
--- a/lib/wt2html/pp/handlers/linter.js
+++ b/lib/wt2html/pp/handlers/linter.js
@@ -862,10 +862,19 @@
detectMultipleUnclosedFormattingTags(lints);
}
+function hasListAncestor(node) {
+ while (node && node.nodeName !== 'LI') {
+ node = node.parentNode;
+ }
+
+ // If the list item comes from references content, ignore it
+ return node &&
!(/mw:Extension\/references/.test(node.parentNode.getAttribute('typeof')));
+}
+
function logPHPParserBug(env, node, dp, tplInfo) {
if (!DU.isLiteralHTMLNode(node) ||
node.nodeName !== 'TABLE' ||
- !DU.hasAncestorOfName(node, 'LI') ||
+ !hasListAncestor(node) ||
!/\n/.test(node.outerHTML)
) {
return;
--
To view, visit https://gerrit.wikimedia.org/r/398418
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: If633fc34584bde6a7f13ba903a563026fd304272
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/services/parsoid
Gerrit-Branch: master
Gerrit-Owner: Subramanya Sastry <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
