Hashar has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/398527 )

Change subject: Prevent puppeteer from downloading Chromium
......................................................................

Prevent puppeteer from downloading Chromium

In production we would use the Chromium package has provided by Debian
and hence there is no need to download a bundled chromium. On CI
Chromium is provided as well.

Ask puppeteer to skip download. That can be achieved either by setting
the environment variable PUPPETEER_SKIP_CHROMIUM_DOWNLOAD or via a
.nmprc local to the repository. The later seems more robust.

Result:

  $ npm install puppeteer@^0.13.0

  > puppeteer@0.13.0 install
  mediawiki/services/chromium-render/node_modules/puppeteer
  > node install.js

  **INFO** Skipping Chromium download.
  "PUPPETEER_SKIP_CHROMIUM_DOWNLOAD" was set in npm config.

The /deploy repository needs a similar adjustement.

Bug: T179552
Change-Id: Ibf6b99d8bf6637cbb926cee13b594589c3dedaca
---
A .npmrc
1 file changed, 1 insertion(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/services/chromium-render 
refs/changes/27/398527/1

diff --git a/.npmrc b/.npmrc
new file mode 100644
index 0000000..0ecb293
--- /dev/null
+++ b/.npmrc
@@ -0,0 +1 @@
+puppeteer_skip_chromium_download = true

-- 
To view, visit https://gerrit.wikimedia.org/r/398527
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibf6b99d8bf6637cbb926cee13b594589c3dedaca
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/services/chromium-render
Gerrit-Branch: master
Gerrit-Owner: Hashar <has...@free.fr>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to