jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/398289 )
Change subject: Fix more_like_api.feature
......................................................................
Fix more_like_api.feature
switch to -30% instead of 70%, this is basically the same thing but it works.
Spent the afternoon trying to figure out the machine running cindy fails on
this one. There must be something really strange happening there since the exact
same query works well locally.
What is strange is that running the query with mininum_should_match set to 99%
returns pages where only one term that match and setting 100% require all terms.
Change-Id: Iae64d730b48f7c83d6827e68a99b6f075153bec3
---
M tests/integration/features/more_like_api.feature
M tests/integration/features/step_definitions/page_steps.js
2 files changed, 2 insertions(+), 2 deletions(-)
Approvals:
Tjones: Looks good to me, but someone else must approve
Cindy-the-browser-test-bot: Looks good to me, but someone else must approve
EBernhardson: Looks good to me, approved
jenkins-bot: Verified
diff --git a/tests/integration/features/more_like_api.feature
b/tests/integration/features/more_like_api.feature
index 95ecd8e..8648a6c 100644
--- a/tests/integration/features/more_like_api.feature
+++ b/tests/integration/features/more_like_api.feature
@@ -39,7 +39,7 @@
And This is Me is not is not part of the api search result
Scenario: Searching for morelike:<page> with the title field and filtering
with the percent terms to match
- When I set More Like This Options to title field, percent terms to match
to 70% and I api search for morelike:More Like Me 1
+ When I set More Like This Options to title field, percent terms to match
to -30% and I api search for morelike:More Like Me 1
Then More Like Me 2 is part of the api search result
And More Like Me 3 is part of the api search result
And More Like Me 4 is part of the api search result
diff --git a/tests/integration/features/step_definitions/page_steps.js
b/tests/integration/features/step_definitions/page_steps.js
index d3dd39f..209bb3c 100644
--- a/tests/integration/features/step_definitions/page_steps.js
+++ b/tests/integration/features/step_definitions/page_steps.js
@@ -406,7 +406,7 @@
return this.stepHelpers.searchFor( search, options );
} );
- When(/^I set More Like This Options to ([^ ]+) field, percent terms to
match to (\d+%) and I api search for (.+)$/, function( field, percent, search )
{
+ When(/^I set More Like This Options to ([^ ]+) field, percent terms to
match to (-?\d+%) and I api search for (.+)$/, function( field, percent, search
) {
let options = {
cirrusMtlUseFields: 'yes',
cirrusMltFields: field,
--
To view, visit https://gerrit.wikimedia.org/r/398289
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iae64d730b48f7c83d6827e68a99b6f075153bec3
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/CirrusSearch
Gerrit-Branch: master
Gerrit-Owner: DCausse <[email protected]>
Gerrit-Reviewer: Cindy-the-browser-test-bot <[email protected]>
Gerrit-Reviewer: EBernhardson <[email protected]>
Gerrit-Reviewer: Gehel <[email protected]>
Gerrit-Reviewer: Smalyshev <[email protected]>
Gerrit-Reviewer: Tjones <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
