Dzahn has submitted this change and it was merged.
Change subject: gerrit: Change repeat from 8-40 to 7-40 for hash in commentlink
......................................................................
gerrit: Change repeat from 8-40 to 7-40 for hash in commentlink
The default abbreviation length in git-cli is 7 for commit
hashes, so it makes sense to link those as well instead of
requiring a minimum length of 8.
Sample:
* 49e06c8 (HEAD, gerrit/production) Dropping all search and preview url's
* 7c0f16b Fix up the mediawiki extension class a bit.
* 7c97b42 Fixing .pyconf module name
* 040cbcf Removing debug statement
* 8c6ab0f I hate when people change parameter names
* 0972bf4 Looking up udp2log socket stats by port instead of socket inode.
Change-Id: Ic2bdb1abba13ac907d889088fa08929068bfda0f
---
M templates/gerrit/gerrit.config.erb
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Demon: Looks good to me, but someone else must approve
jenkins-bot: Verified
Dzahn: Looks good to me, approved
diff --git a/templates/gerrit/gerrit.config.erb
b/templates/gerrit/gerrit.config.erb
index 007acb4..60106dc 100644
--- a/templates/gerrit/gerrit.config.erb
+++ b/templates/gerrit/gerrit.config.erb
@@ -54,10 +54,10 @@
[user]
email = ger...@wikimedia.org
[commentlink "changeid"]
- match = \\b(I[0-9a-f]{8,40})\\b
+ match = \\b(I[0-9a-f]{7,40})\\b
link = "#q,$1,n,z"
[commentlink "commit"]
- match = \\b([0-9a-f]{8,40})\\b
+ match = \\b([0-9a-f]{7,40})\\b
link = "#q,$1,n,z"
[commentlink "bugzilla"]
match = "\\b[bB][uU][gG]\\:?\\s+#?(\\d+)\\b"
--
To view, visit https://gerrit.wikimedia.org/r/56640
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic2bdb1abba13ac907d889088fa08929068bfda0f
Gerrit-PatchSet: 2
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Krinkle <ttij...@wikimedia.org>
Gerrit-Reviewer: Demon <ch...@wikimedia.org>
Gerrit-Reviewer: Dzahn <dz...@wikimedia.org>
Gerrit-Reviewer: QChris <christ...@quelltextlich.at>
Gerrit-Reviewer: Ryan Lane <rl...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
