[MediaWiki-commits] [Gerrit] mediawiki...CategoryTree[master]: Split CategoryPageSubclass.php into two files

[Umherirrender (Code Review)]

Umherirrender has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/398633 )

Change subject: Split CategoryPageSubclass.php into two files
......................................................................

Split CategoryPageSubclass.php into two files

Makes MediaWiki.Files.OneClassPerFile.MultipleFound pass


Change-Id: Ic4d064272a5297e33b1edc090b807937cfb06545
---
M .phpcs.xml
A CategoryTreeCategoryPage.php
R CategoryTreeCategoryViewer.php
M extension.json
4 files changed, 7 insertions(+), 7 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/CategoryTree 
refs/changes/33/398633/1

diff --git a/.phpcs.xml b/.phpcs.xml
index d473d2b..3f9d0cb 100644
--- a/.phpcs.xml
+++ b/.phpcs.xml
@@ -3,7 +3,6 @@
        <rule ref="./vendor/mediawiki/mediawiki-codesniffer/MediaWiki">
                <exclude 
name="MediaWiki.Commenting.FunctionComment.MissingParamComment" />
                <exclude name="MediaWiki.Files.ClassMatchesFilename.NotMatch" />
-               <exclude name="MediaWiki.Files.OneClassPerFile.MultipleFound" />
                <exclude 
name="MediaWiki.Commenting.FunctionComment.MissingDocumentationProtected" />
                <exclude 
name="MediaWiki.Commenting.FunctionComment.MissingDocumentationPublic" />
                <exclude 
name="MediaWiki.WhiteSpace.SpaceBeforeSingleLineComment.NewLineComment" />
diff --git a/CategoryTreeCategoryPage.php b/CategoryTreeCategoryPage.php
new file mode 100644
index 0000000..ebec49f
--- /dev/null
+++ b/CategoryTreeCategoryPage.php
@@ -0,0 +1,5 @@
+<?php
+
+class CategoryTreeCategoryPage extends CategoryPage {
+       public $mCategoryViewerClass = 'CategoryTreeCategoryViewer';
+}
diff --git a/CategoryPageSubclass.php b/CategoryTreeCategoryViewer.php
similarity index 91%
rename from CategoryPageSubclass.php
rename to CategoryTreeCategoryViewer.php
index 56a8853..fabc7f3 100644
--- a/CategoryPageSubclass.php
+++ b/CategoryTreeCategoryViewer.php
@@ -1,9 +1,5 @@
 <?php
 
-class CategoryTreeCategoryPage extends CategoryPage {
-       public $mCategoryViewerClass = 'CategoryTreeCategoryViewer';
-}
-
 class CategoryTreeCategoryViewer extends CategoryViewer {
        public $child_cats;
 
diff --git a/extension.json b/extension.json
index e56aafc..c993c6b 100644
--- a/extension.json
+++ b/extension.json
@@ -29,8 +29,8 @@
        "AutoloadClasses": {
                "CategoryTreePage": "CategoryTreePage.php",
                "CategoryTree": "CategoryTreeFunctions.php",
-               "CategoryTreeCategoryPage": "CategoryPageSubclass.php",
-               "CategoryTreeCategoryViewer": "CategoryPageSubclass.php",
+               "CategoryTreeCategoryPage": "CategoryTreeCategoryPage.php",
+               "CategoryTreeCategoryViewer": "CategoryTreeCategoryViewer.php",
                "CategoryTreeHooks": "CategoryTree.hooks.php",
                "CategoryTreeMode": "CategoryTreeMode.php",
                "CategoryTreeHidePrefix": "CategoryTreeHidePrefix.php",

-- 
To view, visit https://gerrit.wikimedia.org/r/398633
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic4d064272a5297e33b1edc090b807937cfb06545
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/CategoryTree
Gerrit-Branch: master
Gerrit-Owner: Umherirrender <umherirrender_de...@web.de>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits