Hello jenkins-bot,
I'd like you to do a code review. Please visit
https://gerrit.wikimedia.org/r/398637
to review the following change.
Change subject: Revert "use cat to recombine gzipped files together"
......................................................................
Revert "use cat to recombine gzipped files together"
This reverts commit faf7de86d3dd98b4e5bd59809c5938050fbec42d.
A nice idea but we woudl wind up with multiple site headers in the concatenated
file, changing the contents.
Change-Id: I7da9a95c0c817b529f40ce024235c1afbe85600f
---
M xmldumps-backup/dumps/recombinejobs.py
1 file changed, 9 insertions(+), 9 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/operations/dumps
refs/changes/37/398637/1
diff --git a/xmldumps-backup/dumps/recombinejobs.py
b/xmldumps-backup/dumps/recombinejobs.py
index ce5e580..12c49e5 100644
--- a/xmldumps-backup/dumps/recombinejobs.py
+++ b/xmldumps-backup/dumps/recombinejobs.py
@@ -129,11 +129,11 @@
if not len(input_dfnames):
self.set_status("failed")
raise BackupError("No input files for %s found" % self.name())
- if not exists(runner.wiki.config.cat):
- raise BackupError("cat command %s not found" %
runner.wiki.config.cat)
- compression_command = runner.wiki.config.cat
- compression_command = "%s > " % runner.wiki.config.cat
- uncompression_command = ["%s" % runner.wiki.config.cat]
+ if not exists(runner.wiki.config.gzip):
+ raise BackupError("gzip command %s not found" %
runner.wiki.config.gzip)
+ compression_command = runner.wiki.config.gzip
+ compression_command = "%s > " % runner.wiki.config.gzip
+ uncompression_command = ["%s" % runner.wiki.config.gzip, "-dc"]
recombine_command_string = self.build_recombine_command_string(
runner, input_dfnames, output_dfname, compression_command,
uncompression_command)
recombine_command = [recombine_command_string]
@@ -301,10 +301,10 @@
if not len(input_dfnames):
self.set_status("failed")
raise BackupError("No input files for %s found" % self.name())
- if not exists(runner.wiki.config.cat):
- raise BackupError("cat command %s not found" %
runner.wiki.config.cat)
- compression_command = "%s > " % runner.wiki.config.cat
- uncompression_command = ["%s" % runner.wiki.config.cat]
+ if not exists(runner.wiki.config.gzip):
+ raise BackupError("gzip command %s not found" %
runner.wiki.config.gzip)
+ compression_command = "%s > " % runner.wiki.config.gzip
+ uncompression_command = ["%s" % runner.wiki.config.gzip, "-dc"]
recombine_command_string = self.build_recombine_command_string(
runner, input_dfnames, output_dfname, compression_command,
uncompression_command, "<feed>")
--
To view, visit https://gerrit.wikimedia.org/r/398637
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7da9a95c0c817b529f40ce024235c1afbe85600f
Gerrit-PatchSet: 1
Gerrit-Project: operations/dumps
Gerrit-Branch: master
Gerrit-Owner: ArielGlenn <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
