Umherirrender has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/398643 )

Change subject: Move InterwikiLogFormatter to own file
......................................................................

Move InterwikiLogFormatter to own file

Makes MediaWiki.Files.OneClassPerFile.MultipleFound pass

Change-Id: I463de4435b1f1ef82b9e87b35ebc3ad16e181898
---
M .phpcs.xml
A InterwikiLogFormatter.php
M Interwiki_body.php
M extension.json
4 files changed, 18 insertions(+), 18 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Interwiki 
refs/changes/43/398643/1

diff --git a/.phpcs.xml b/.phpcs.xml
index 3cb24ee..e2ae5f1 100644
--- a/.phpcs.xml
+++ b/.phpcs.xml
@@ -2,7 +2,6 @@
 <ruleset>
        <rule ref="./vendor/mediawiki/mediawiki-codesniffer/MediaWiki">
                <exclude name="MediaWiki.Files.ClassMatchesFilename.NotMatch" />
-               <exclude name="MediaWiki.Files.OneClassPerFile.MultipleFound" />
                <exclude 
name="MediaWiki.Commenting.FunctionComment.MissingDocumentationProtected" />
                <exclude 
name="MediaWiki.Commenting.FunctionComment.MissingDocumentationPublic" />
                <exclude 
name="MediaWiki.WhiteSpace.SpaceBeforeSingleLineComment.NewLineComment" />
diff --git a/InterwikiLogFormatter.php b/InterwikiLogFormatter.php
new file mode 100644
index 0000000..ecdce1a
--- /dev/null
+++ b/InterwikiLogFormatter.php
@@ -0,0 +1,17 @@
+<?php
+
+/**
+ * Needed to pass the URL as a raw parameter, because it contains $1
+ */
+class InterwikiLogFormatter extends LogFormatter {
+       /**
+        * @return array
+        */
+       protected function getMessageParameters() {
+               $params = parent::getMessageParameters();
+               if ( isset( $params[4] ) ) {
+                       $params[4] = Message::rawParam( htmlspecialchars( 
$params[4] ) );
+               }
+               return $params;
+       }
+}
diff --git a/Interwiki_body.php b/Interwiki_body.php
index f055205..c6c37ca 100644
--- a/Interwiki_body.php
+++ b/Interwiki_body.php
@@ -496,19 +496,3 @@
                return 'wiki';
        }
 }
-
-/**
- * Needed to pass the URL as a raw parameter, because it contains $1
- */
-class InterwikiLogFormatter extends LogFormatter {
-       /**
-        * @return array
-        */
-       protected function getMessageParameters() {
-               $params = parent::getMessageParameters();
-               if ( isset( $params[4] ) ) {
-                       $params[4] = Message::rawParam( htmlspecialchars( 
$params[4] ) );
-               }
-               return $params;
-       }
-}
diff --git a/extension.json b/extension.json
index afc108e..e409d9f 100644
--- a/extension.json
+++ b/extension.json
@@ -58,7 +58,7 @@
        "AutoloadClasses": {
                "InterwikiHooks": "Interwiki_hooks.php",
                "SpecialInterwiki": "Interwiki_body.php",
-               "InterwikiLogFormatter": "Interwiki_body.php"
+               "InterwikiLogFormatter": "InterwikiLogFormatter.php"
        },
        "manifest_version": 1
 }

-- 
To view, visit https://gerrit.wikimedia.org/r/398643
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I463de4435b1f1ef82b9e87b35ebc3ad16e181898
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Interwiki
Gerrit-Branch: master
Gerrit-Owner: Umherirrender <umherirrender_de...@web.de>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to