Rafidaslam has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/398672 )
Change subject: SpecialGlobalContributions: Avoid &$this in hooks
......................................................................
SpecialGlobalContributions: Avoid &$this in hooks
&$this triggers warnings in PHP 7.1. Simply renaming the variable before
passing it by reference avoids the warning, without breaking backwards
compatibility.
Bug: T153505
Change-Id: I11b8f07a90e0ccb7fabe1f99f3bba7c7d83c1437
---
M SpecialGlobalContributions.php
1 file changed, 3 insertions(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/GlobalContribs
refs/changes/72/398672/1
diff --git a/SpecialGlobalContributions.php b/SpecialGlobalContributions.php
index 58139b3..ad0c759 100644
--- a/SpecialGlobalContributions.php
+++ b/SpecialGlobalContributions.php
@@ -369,7 +369,9 @@
$this->tagFilter
);
- Hooks::run( 'ContribsPager::getQueryInfo', array( &$this,
&$queryInfo ) );
+ // Avoid PHP 7.1 warning of passing $this by reference
+ $globalContribsPager = $this;
+ Hooks::run( 'ContribsPager::getQueryInfo', array(
&$globalContribsPager, &$queryInfo ) );
return $queryInfo;
}
--
To view, visit https://gerrit.wikimedia.org/r/398672
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I11b8f07a90e0ccb7fabe1f99f3bba7c7d83c1437
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/GlobalContribs
Gerrit-Branch: master
Gerrit-Owner: Rafidaslam <rafidt...@gmail.com>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
