jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/398691 )
Change subject: Fix gap between header and content
......................................................................
Fix gap between header and content
After a long analysis on IRC I've found out that the cause isn't
the fieldset as described in the bug report, but a margin-top rule.
Bug: T174139
Change-Id: Ifde1a944ca19e424ff5499c5f2cd1c362dc6e23b
---
M modules/ui/legacy/styles/mw.cx.ui.Columns.less
M modules/ui/styles/mw.cx.ui.Columns.less
M modules/widgets/common/ext.cx.column.less
3 files changed, 3 insertions(+), 3 deletions(-)
Approvals:
Zppix: Looks good to me, but someone else must approve
jenkins-bot: Verified
Santhosh: Looks good to me, approved
diff --git a/modules/ui/legacy/styles/mw.cx.ui.Columns.less
b/modules/ui/legacy/styles/mw.cx.ui.Columns.less
index 960286e..1435014 100644
--- a/modules/ui/legacy/styles/mw.cx.ui.Columns.less
+++ b/modules/ui/legacy/styles/mw.cx.ui.Columns.less
@@ -2,7 +2,7 @@
@import '../../../widgets/common/ext.cx.common.less';
.cx-widget__columns {
- margin-top: 100px;
+ margin-top: 80px;
min-height: 100vh;
&.disabled {
diff --git a/modules/ui/styles/mw.cx.ui.Columns.less
b/modules/ui/styles/mw.cx.ui.Columns.less
index b83874f..8900364 100644
--- a/modules/ui/styles/mw.cx.ui.Columns.less
+++ b/modules/ui/styles/mw.cx.ui.Columns.less
@@ -2,7 +2,7 @@
@import '../../widgets/common/ext.cx.common.less';
.cx-widget__columns {
- margin-top: 100px;
+ margin-top: 80px;
min-height: 100vh;
&.disabled {
diff --git a/modules/widgets/common/ext.cx.column.less
b/modules/widgets/common/ext.cx.column.less
index 634caf7..d3b18fc 100644
--- a/modules/widgets/common/ext.cx.column.less
+++ b/modules/widgets/common/ext.cx.column.less
@@ -2,7 +2,7 @@
@import 'ext.cx.common.less';
.cx-widget__columns {
- margin-top: 100px;
+ margin-top: 80px;
min-height: 100vh;
&.disabled {
--
To view, visit https://gerrit.wikimedia.org/r/398691
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ifde1a944ca19e424ff5499c5f2cd1c362dc6e23b
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/ContentTranslation
Gerrit-Branch: master
Gerrit-Owner: Divadsn <[email protected]>
Gerrit-Reviewer: Amire80 <[email protected]>
Gerrit-Reviewer: D3r1ck <[email protected]>
Gerrit-Reviewer: KartikMistry <[email protected]>
Gerrit-Reviewer: Nikerabbit <[email protected]>
Gerrit-Reviewer: Santhosh <[email protected]>
Gerrit-Reviewer: Siebrand <[email protected]>
Gerrit-Reviewer: Zppix <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
