Legoktm has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/399132 )
Change subject: RevisionTest: Revision::constructFromRowArray is not a function
......................................................................
RevisionTest: Revision::constructFromRowArray is not a function
I'm guessing that RevisionStore::newMutableRevisionFromArray() is
what is supposed to be tested here, since Revision::__construct()
calls that if it gets an array.
Change-Id: Ia6c2e7eb667aa746a12ce74aad62e58d2468defd
---
M tests/phpunit/includes/RevisionTest.php
1 file changed, 3 insertions(+), 3 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/32/399132/1
diff --git a/tests/phpunit/includes/RevisionTest.php
b/tests/phpunit/includes/RevisionTest.php
index b7f1a47d..f4ad98d 100644
--- a/tests/phpunit/includes/RevisionTest.php
+++ b/tests/phpunit/includes/RevisionTest.php
@@ -57,7 +57,7 @@
/**
* @dataProvider provideConstructFromArray
* @covers Revision::__construct
- * @covers Revision::constructFromRowArray
+ * @covers \MediaWiki\Storage\RevisionStore::newMutableRevisionFromArray
*/
public function testConstructFromArray( $rowArray ) {
$rev = new Revision( $rowArray, 0, $this->getMockTitle() );
@@ -68,7 +68,7 @@
/**
* @covers Revision::__construct
- * @covers Revision::constructFromRowArray
+ * @covers \MediaWiki\Storage\RevisionStore::newMutableRevisionFromArray
*/
public function testConstructFromEmptyArray() {
$rev = new Revision( [], 0, $this->getMockTitle() );
@@ -106,7 +106,7 @@
/**
* @dataProvider provideConstructFromArray_userSetAsExpected
* @covers Revision::__construct
- * @covers Revision::constructFromRowArray
+ * @covers \MediaWiki\Storage\RevisionStore::newMutableRevisionFromArray
*
* @param array $rowArray
* @param mixed $expectedUserId null to expect the current wgUser ID
--
To view, visit https://gerrit.wikimedia.org/r/399132
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia6c2e7eb667aa746a12ce74aad62e58d2468defd
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Legoktm <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
