jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/389648 )

Change subject: Add fallback to getting Preferences and Notifications URLs
......................................................................


Add fallback to getting Preferences and Notifications URLs

Change-Id: I0ab756cafcbd535fa1765fd12fdd72bb75f0df62
---
M modules/ext.echo.init.js
1 file changed, 3 insertions(+), 2 deletions(-)

Approvals:
  jenkins-bot: Verified
  Nikerabbit: Looks good to me, approved



diff --git a/modules/ext.echo.init.js b/modules/ext.echo.init.js
index b5e0962..90cf08d 100644
--- a/modules/ext.echo.init.js
+++ b/modules/ext.echo.init.js
@@ -26,8 +26,9 @@
                        hasUnseenMessages = $existingMessageLink.hasClass( 
'mw-echo-unseen-notifications' ),
                        // Store links
                        links = {
-                               notifications: $( '#pt-notifications-alert a' 
).attr( 'href' ),
-                               preferences: $( '#pt-preferences a' ).attr( 
'href' ) + '#mw-prefsection-echo'
+                               notifications: $( '#pt-notifications-alert a' 
).attr( 'href' ) || mw.util.getUrl( 'Special:Notifications' ),
+                               preferences: ( $( '#pt-preferences a' ).attr( 
'href' ) || mw.util.getUrl( 'Special:Preferences' ) ) +
+                                       '#mw-prefsection-echo'
                        };
 
                // Respond to click on the notification button and load the UI 
on demand

-- 
To view, visit https://gerrit.wikimedia.org/r/389648
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I0ab756cafcbd535fa1765fd12fdd72bb75f0df62
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/extensions/Echo
Gerrit-Branch: master
Gerrit-Owner: Petar.petkovic <[email protected]>
Gerrit-Reviewer: Catrope <[email protected]>
Gerrit-Reviewer: Nikerabbit <[email protected]>
Gerrit-Reviewer: Petar.petkovic <[email protected]>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to