Awight has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/398942 )

Change subject: Clean up logging config.
......................................................................


Clean up logging config.

Add modules we're interested in, as knobs to be turned when desired.

Make the format string nicer, and provide a variant for debugging problems
where threading would make it hard to read.

Bug: T182614
Change-Id: Ie6f36290d2afef2a77e44bbd5d36f0994cc65a1a
---
M logging_config.yaml
1 file changed, 23 insertions(+), 10 deletions(-)

Approvals:
  Halfak: Verified; Looks good to me, approved



diff --git a/logging_config.yaml b/logging_config.yaml
index aff222d..68cfc82 100644
--- a/logging_config.yaml
+++ b/logging_config.yaml
@@ -1,21 +1,26 @@
 version: 1
 
+root:
+  handlers: [file]
+
 loggers:
+
   revscoring:
     level: ERROR
-    handlers: [file]
   ores:
     level: ERROR
-    handlers: [file]
+  ores.metrics_collectors.logger:
+    level: ERROR
   celery:
     level: ERROR
-    handlers: [file]
+  requests:
+    level: ERROR
+  revscoring.dependencies.dependent:
+    level: ERROR
+  stopit:
+    level: ERROR
 
 handlers:
-  stdout:
-    class: logging.StreamHandler
-    formatter: basic_human
-    stream: ext://sys.stdout
   file:
     class: logging.handlers.TimedRotatingFileHandler
     filename: /srv/log/ores/app.log
@@ -23,7 +28,15 @@
     when: midnight
     backupCount: 7
 
-formatters:
-  basic_human: 
-    format: "%(asctime)s %(levelname)s:%(name)s -- %(message)s"
+  syslog:
+    class: logging.handlers.SysLogHandler
+    formatter: basic_human
+    address: /dev/log
 
+formatters:
+  basic_human:
+    format: "%(asctime)s %(levelname)s %(name)s: %(message)s"
+
+  # Extra verbosity for untangling threads:
+  threaded:
+    format: "s%(asctime)s %(levelname)s %(name)s [P%(process)d T%(thread)d]: 
%(message)s"

-- 
To view, visit https://gerrit.wikimedia.org/r/398942
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ie6f36290d2afef2a77e44bbd5d36f0994cc65a1a
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/services/ores/deploy
Gerrit-Branch: master
Gerrit-Owner: Awight <awi...@wikimedia.org>
Gerrit-Reviewer: Awight <awi...@wikimedia.org>
Gerrit-Reviewer: Halfak <ahalfa...@wikimedia.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to