jenkins-bot has submitted this change and it was merged.
Change subject: Test: Disable circular reference test for ve.getHash.
......................................................................
Test: Disable circular reference test for ve.getHash.
Change-Id: Idbad334ed21247c3f4d442f6aad62a0b9347cfc6
---
M modules/ve/test/ve.test.js
1 file changed, 7 insertions(+), 1 deletion(-)
Approvals:
Catrope: Looks good to me, approved
jenkins-bot: Verified
diff --git a/modules/ve/test/ve.test.js b/modules/ve/test/ve.test.js
index 6e8659c..80d15a8 100644
--- a/modules/ve/test/ve.test.js
+++ b/modules/ve/test/ve.test.js
@@ -180,7 +180,7 @@
);
} );
-QUnit.test( 'getHash: Complex usage', 4, function ( assert ) {
+QUnit.test( 'getHash: Complex usage', 3, function ( assert ) {
var obj, hash, frame;
obj = {
@@ -203,11 +203,17 @@
);
// Include a circular reference
+ /*
+ * PhantomJS hangs when calling JSON.stringify with an object
containing a
+ * circular reference (https://github.com/ariya/phantomjs/issues/11206).
+ * We know latest Chrome/Firefox and IE8+ support this. So, for the
sake of
+ * having qunit/phantomjs work, lets disable this for now.
obj.f = obj;
assert.throws( function () {
ve.getHash( obj );
}, 'Throw exceptions for objects with cirular refences ' );
+ */
function Foo() {
this.a = 1;
--
To view, visit https://gerrit.wikimedia.org/r/57455
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Idbad334ed21247c3f4d442f6aad62a0b9347cfc6
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Krinkle <[email protected]>
Gerrit-Reviewer: Catrope <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
