jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/396462 )
Change subject: Remove old string-based API description functions
......................................................................
Remove old string-based API description functions
These have been deprecated since MediaWiki core 1.25 and no longer have any
effect.
Change-Id: Icbaaa395af8303c1018e92ab2bfddb02ed587115
---
M includes/ApiQueryPageImages.php
M tests/phpunit/ApiQueryPageImagesTest.php
2 files changed, 0 insertions(+), 37 deletions(-)
Approvals:
jenkins-bot: Verified
Jdlrobson: Looks good to me, approved
diff --git a/includes/ApiQueryPageImages.php b/includes/ApiQueryPageImages.php
index 3476668..64ed50b 100644
--- a/includes/ApiQueryPageImages.php
+++ b/includes/ApiQueryPageImages.php
@@ -234,13 +234,6 @@
}
/**
- * @deprecated since MediaWiki core 1.25
- */
- public function getDescription() {
- return 'Returns information about images on the page such as
thumbnail and presence of photos.';
- }
-
- /**
* Return an array describing all possible parameters to this module
* @return array
*/
@@ -277,22 +270,6 @@
defined( 'ApiBase::PARAM_HELP_MSG' )
? ApiBase::PARAM_HELP_MSG : '' =>
'api-help-param-continue',
],
- ];
- }
-
- /**
- * @deprecated since MediaWiki core 1.25
- */
- public function getParamDescription() {
- return [
- 'prop' => [ 'What information to return',
- ' thumbnail - URL and dimensions of image
associated with page, if any',
- ' name - image title',
- ' original - URL and dimensions of the original
image',
- ],
- 'thumbsize' => 'Maximum width in pixels of thumbnail
images',
- 'limit' => 'Properties of how many pages to return',
- 'continue' => 'When more results are available, use
this to continue',
];
}
diff --git a/tests/phpunit/ApiQueryPageImagesTest.php
b/tests/phpunit/ApiQueryPageImagesTest.php
index 20dfe3d..688f454 100644
--- a/tests/phpunit/ApiQueryPageImagesTest.php
+++ b/tests/phpunit/ApiQueryPageImagesTest.php
@@ -76,13 +76,6 @@
$this->assertInstanceOf( 'ApiQueryPageImages', $instance );
}
- public function testGetDescription() {
- $instance = $this->newInstance();
- $description = $instance->getDescription();
- $this->assertInternalType( 'string', $description );
- $this->assertNotEmpty( $description );
- }
-
public function testGetCacheMode() {
$instance = $this->newInstance();
$this->assertSame( 'public', $instance->getCacheMode( [] ) );
@@ -104,13 +97,6 @@
$this->assertEquals( $params['license'][\ApiBase::PARAM_TYPE],
[ 'free', 'any' ] );
$this->assertEquals( $params['license'][\ApiBase::PARAM_DFLT],
'free' );
$this->assertEquals(
$params['license'][\ApiBase::PARAM_ISMULTI], false );
- }
-
- public function testGetParamDescription() {
- $instance = $this->newInstance();
- $descriptions = $instance->getParamDescription();
- $this->assertInternalType( 'array', $descriptions );
- $this->assertNotEmpty( $descriptions );
}
/**
--
To view, visit https://gerrit.wikimedia.org/r/396462
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Icbaaa395af8303c1018e92ab2bfddb02ed587115
Gerrit-PatchSet: 5
Gerrit-Project: mediawiki/extensions/PageImages
Gerrit-Branch: master
Gerrit-Owner: Pppery <[email protected]>
Gerrit-Reviewer: Jdlrobson <[email protected]>
Gerrit-Reviewer: Pppery <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
