ArielGlenn has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/399392 )
Change subject: when creating lists of dump files for rsync, don't bail on
bogus error
......................................................................
when creating lists of dump files for rsync, don't bail on bogus error
The "some files failes to be transferred" thing is always a red
herring, and bailing doesn't win us anything, the list is already
written out by then.
Change-Id: Ifb74bf437605c32cbb0d0851d999df2a0e9c45cd
---
M modules/dumps/files/web/list-last-n-good-dumps.py
1 file changed, 4 insertions(+), 0 deletions(-)
Approvals:
ArielGlenn: Looks good to me, approved
jenkins-bot: Verified
diff --git a/modules/dumps/files/web/list-last-n-good-dumps.py
b/modules/dumps/files/web/list-last-n-good-dumps.py
index 7b50990..85b04ad 100755
--- a/modules/dumps/files/web/list-last-n-good-dumps.py
+++ b/modules/dumps/files/web/list-last-n-good-dumps.py
@@ -418,6 +418,10 @@
# output will be None, we can ignore it
dummy_output, error = proc.communicate()
if proc.returncode:
+ if 'some files/attrs were not transferred' in error:
+ # this can be files that are being rewritten at
+ # the moment, we don't care.
+ return
raise DumpListError(
"command '" + command_string +
("' failed with return code %s " % proc.returncode) +
--
To view, visit https://gerrit.wikimedia.org/r/399392
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ifb74bf437605c32cbb0d0851d999df2a0e9c45cd
Gerrit-PatchSet: 2
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: ArielGlenn <[email protected]>
Gerrit-Reviewer: ArielGlenn <[email protected]>
Gerrit-Reviewer: Volans <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
